Issue installing aidge_learning

Problem description

After successfully installing aidge_learning, the code for importing the library returns an error concerning the SGD (see the error below).

(env_aidge2) C:\Users\vboyer\aidge2\aidge>python -c "import aidge_learning"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "D:\MiniConda\envs\env_aidge2\lib\site-packages\aidge_learning-0.1.2-py3.8-win-amd64.egg\aidge_learning\__init__.py", line 11, in <module>
    from aidge_learning.aidge_learning import *
ImportError: generic_type: type "SGD" referenced unknown base type "Aidge::Attributes"

Hello @valarcys Thanks for your issue !

Attribute is no longer an inheritance and hasn't been removed as such in the binding

Removing Attribute from the list of inheritance should fix: https://gitlab.eclipse.org/eclipse/aidge/aidge_learning/-/blob/main/python_binding/learning/optimizer/pybind_SGD.cpp?ref_type=heads#L22

Note: same for Adam: https://gitlab.eclipse.org/eclipse/aidge/aidge_learning/-/blob/main/python_binding/learning/optimizer/pybind_Adam.cpp?ref_type=heads#L22

Otherwise the fix is quite simple and if someone wants to propose a MR to fix this issue we will gladly accept it :)

Cheers,

Cyril

Note: My bad the change also hasn't been made in C++ code https://gitlab.eclipse.org/eclipse/aidge/aidge_learning/-/blob/main/include/aidge/learning/optimizer/SGD.hpp?ref_type=heads#L32

@hrouis didn't you face this issue in !13 (closed) ?

Maybe you can fix this ?

For any one interrested in fixing this issue here is the commit made by @pineapple that change the attribute from inheritence to an attribute in Operator: aidge_core@76c35de6

The changes should be similar here !

I only get the error if I try to import aidge_learning without importing aidge_core before.

@valarcys I believe if you callpython -c "import aidge_core; import aidge_learning" you won't get the error

@hrouis Oh I just tested it and it works, don't know why I didn't think about that. Thanks a lot!

no problem ;)

added Bug 🐛 Good First Issue labels

The issue seems to be solved (need to import aidge_core first!). Closing, please feel free to re-open it if needed.

closed