Skip to content
Snippets Groups Projects

[fix] Fix Conv DW and softmax for mobile_net_v1

Merged [fix] Fix Conv DW and softmax for mobile_net_v1
wboussella/aidge_export_arm_cortexm:fix_mobile_net_v1 into dev
All threads resolved!
Merged Wissam Boussella requested to merge wboussella/aidge_export_arm_cortexm:fix_mobile_net_v1 into dev
All threads resolved!

Context

ConvDW was considered as a Conv, which created a lot of issues

Modified files

  • operator.py Change the template called
  • ConvDW.hpp, SumT was not declared correctly
  • aidge_softmax_chw_float32.c, Softmax and their templates was not correct
Edited by Wissam Boussella

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Cyril Moineau
  • Cyril Moineau
  • Cyril Moineau
  • Cyril Moineau
  • Cyril Moineau
  • Cyril Moineau
  • Wissam Boussella added 1 commit

    added 1 commit

    • 1d321c95 - [fix] fix for the MR, changing sum_t by bias_t in ConvDW , removing...

    Compare with previous version

  • Wissam Boussella
    Wissam Boussella @wboussella ·
    Author Reporter

    @cmoineau i've modified my code :)

  • Cyril Moineau resolved all threads

    resolved all threads

  • Cyril Moineau
    Cyril Moineau @cmoineau ·
    Maintainer

    All thread are solved the MR looks good to me I will run the pipeline (there is no pipeline for arm :'() and set to auto merge!

    Thanks for your contribution @wboussella :smiley:

    Edited by Cyril Moineau
  • Cyril Moineau mentioned in commit 1a4b72ef

    mentioned in commit 1a4b72ef

  • Cyril Moineau merged

    merged

  • Olivier BICHLER mentioned in issue #29 (closed)

    mentioned in issue #29 (closed)

    • Please register or sign in to reply

    Copyright © Eclipse Foundation, Inc. All Rights Reserved.     Privacy Policy | Terms of Use | Copyright Agent