[Upd] replace() instead of replaceWith() in GraphView

Description of replaceWith()

The replaceWith() member function works as follow:

1. Select a set of Nodes to replace
2. Create a GraphView from this set. (let's call it g)
3. Select a set of new Nodes and solve their input connections (let's call it newNodes)
4. run g.replaceWith(newNodes)
5. Nodes are replaced in every GraphView pointing at them all

Issue

1. It may be confusing to create a new GraphView from the set of Nodes to replace and replace it by another set of Nodes and not a GraphView
2. Input connections are not handled at all
3. Output connections are handled and authorized only if obvious

Solution

Change replaceWith() by replace()

GraphView::replace(std::set<std::shared_ptr<Node>> oldNodes, std::set<std::shared_ptr<Node>> newNodes);

1. symetric handling of old/new Nodes
2. automatically recreate input AND output connections if obvious (one connection or every input pointing to the same Tensor)

include/aidge/graph/GraphView.hpp

@@ -322,26 +322,33 @@ public:
 
     /**
      * @brief Insert a node (newParentNode) as a parent of the passed node (childNode).
-     * 
+     *
      * @param childNode Node that gets a new parent.
      * @param newParentNode Inserted Node.
      * @param childInputTensorIdx Index of the input Tensor for the childNode linked to the inserted Node output.
      * @param newParentInputTensorIdx Index of the input Tensor for the newParentNode linked to the former parent of childNode.
      * @param newParentOutputTensorIdx Index of the output Tensor for the newParentNode linked to the childNode's input Tensor.
      */
-    void insertParent(NodePtr childNode, 
-                        NodePtr newParentNode, 
-                        IOIndex_t childInputTensorIdx, 
-                        IOIndex_t newParentInputTensorIdx, 
+    void insertParent(NodePtr childNode,
+                        NodePtr newParentNode,
+                        IOIndex_t childInputTensorIdx,
+                        IOIndex_t newParentInputTensorIdx,
                         IOIndex_t newParentOutputTensorIdx);
 
+
     /**
-     * @brief Replace the current GraphView with the set of given Nodes if possible
-     * @param newNodes Set of Nodes.
+     * @brief Replace a set of Nodes in every available GraphView with a new set of Nodes if possible.
+     * Both sets should include all the necessary Producers.
+     * @details Replaced Nodes are removed from any GraphView pointing at them all.
+     * The oldNodes set should have only one input/output
+     * Tensor for automatic connections of newNodes set.
+     * @param oldNodes actual set of shared_ptr<Node> to replace.
+     * @param newNodes new set of shared_ptr<Node>.
      * @return true
      * @return false
      */
-    bool replaceWith(std::set<NodePtr> newNodes);
+    static bool replace(const std::set<NodePtr>& oldNodes, const std::set<NodePtr>& newNodes);
+
     void updateInputNodes();
     /**
      * @brief Process from zero the set of output Nodes.
@@ -379,6 +386,12 @@ public:
      */
     std::shared_ptr<GraphView> cloneCallback(NodePtr(*cloneNode)(NodePtr)) const;
 
+    /**
+     * @brief Get the sum of the number of free dataInput connection for all inputNodes of the GraphView object.
+     * @return IOIndex_t
+     */
+    IOIndex_t getNbFreeDataInputs() const;
+
 private:
 ///////////////////////////////////////////////////////
 //        TENSOR MANAGEMENT
@@ -390,12 +403,6 @@ private:
      */
     IOIndex_t getNbDataInputs() const;
 
-    /**
-     * @brief Get the sum of the number of free dataInput connection for all inputNodes of the GraphView object.
-     * @return IOIndex_t
-     */
-    IOIndex_t getNbFreeDataInputs() const;
-
     /**
      * @brief Update the set of inputNodes with a new Node, checking if it can be
      * added and removing any Node not part of mInputNode anymore.