Skip to content

Handle Node connection custom and default names

Charles Villard requested to merge silvanosky/aidge_core:features/io_names_1 into dev

Context

Connections names between the nodes is implicit. These are explicited only when exporting to onnx in the onnx module.

This behavior let the aidge_onnx module to guess the naming when importing and exporting. This doesn't allow the custom name on input and output nodes of the network to be saved. Hence, when import and export a network, the output network will have new names on the input and output tensor which make it difficult for interoperability of the names which expect data to be put on some tensors names.

Modified files

  • include/aidge/graph/Node.hpp
  • python_binding/graph/pybind_Node.cpp
  • src/graph/Node.cpp

Detailed major modifications

Nodes have their default names the same as produced by aidge_onnx. But if a custom name is provided, the output and input of the connection will be updated for the output. This simplifies the aidge_onnx module, which won't have to handle names anymore in a following merge request.

As far of the aidge_core itself, this approach does not impact the graph behavior.

Merge request reports

Loading