Fix Cast_Op not working
Context
As stated by the issue #250 (closed), Cast operator was not working.
This was due to the method setDataType()
of OperatorTensor
that was overwriting the output type.
This MR is dedicated to overwrite the method setDataType()
of Cast_Op
to set output type as targetType
.
Modified files
-
Cast.hpp
andCast.cpp
, addsetDataType()
forCast_Op
;
Merge request reports
Activity
changed milestone to %aidge v0.7.0
added Fix 🔥🔥 Important ❗ StatusReview Ready TopicOperator labels
requested review from @pineapple and @olivierbichler
assigned to @hrouis
mentioned in issue #250 (closed)
36 36 mOutputs[0]->setDataType(targetType); 37 37 } 38 38 39 void Aidge::Cast_Op::setDataType(const DataType& dataType) const { This seems way too complicated and useless! First, Cast operator only have one input and one output. Second, the output data type is already set! Instead, I propose to just have a single line: a
Log.warn()
if the data type argument is different from target type in order to signal to the user that the cast output type is fixed at creation.@hrouis Can you apply the change proposed by @olivierbichler?
changed this line in version 3 of the diff
removed StatusReview Ready label
added StatusChanges required label
added 32 commits
-
30566ca7...2afc296e - 31 commits from branch
dev
- efd11a98 - override setDataType for Cast_op
-
30566ca7...2afc296e - 31 commits from branch
- Resolved by Olivier BICHLER
reset approvals from @pineapple by pushing to the branch
enabled an automatic merge when all merge checks for e5cafb54 pass
changed milestone to %aidge v0.6.0