Skip to content
Snippets Groups Projects

Fix Cast_Op not working

Merged Houssem ROUIS requested to merge fix_cast into dev
1 unresolved thread

Context

As stated by the issue #250 (closed), Cast operator was not working. This was due to the method setDataType() of OperatorTensor that was overwriting the output type.
This MR is dedicated to overwrite the method setDataType() of Cast_Op to set output type as targetType.

Modified files

  • Cast.hpp and Cast.cpp, add setDataType() for Cast_Op;

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
36 36 mOutputs[0]->setDataType(targetType);
37 37 }
38 38
39 void Aidge::Cast_Op::setDataType(const DataType& dataType) const {
  • Houssem ROUIS added 32 commits

    added 32 commits

    Compare with previous version

  • Maxence Naud approved this merge request

    approved this merge request

  • added 1 commit

    • d7959d40 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Olivier BICHLER reset approvals from @pineapple by pushing to the branch

    reset approvals from @pineapple by pushing to the branch

  • Olivier BICHLER added 3 commits

    added 3 commits

    • c2410067 - 1 commit from branch dev
    • 7edea134 - override setDataType for Cast_op
    • e5cafb54 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Olivier BICHLER approved this merge request

    approved this merge request

  • Olivier BICHLER enabled an automatic merge when all merge checks for e5cafb54 pass

    enabled an automatic merge when all merge checks for e5cafb54 pass

  • Cyril Moineau changed milestone to %aidge v0.6.0

    changed milestone to %aidge v0.6.0

  • Please register or sign in to reply
    Loading