[Feat] ForwardDims Conv for NCHW and NHWC

Context

Now forward_dims works for NHWC and NCHW dataformat

Resolves issue #223 (closed)

Modified files

• feat: Conv.hpp, now Conv_Op::inChannels() checks if the Weight Producer format is [Cout,H,W,Cin] or [Cout,Cin,H,W];
• upd: Conv::forwardDims() accounts for weight data format (NHWC or NCHW)

include/aidge/data/Tensor.hpp

@@ -462,12 +462,39 @@ public:
      *                  data is copy-transposed.
      */
     void setDataFormat(const DataFormat df, bool copyTrans = true) {
-        if (mImpl && copyTrans && (dataFormat() != df) && df != DataFormat::Default && dataFormat() != DataFormat::Default) {
-            copyTranspose(*this, getDataFormatTranspose(dataFormat(), df));
+        if (!copyTrans || df == dataFormat()) {
+            mDataFormat = df;
+            return;
         }
+    
+        if ((df == DataFormat::Default && dataFormat() == DataFormat::Default) || 
+            (df == DataFormat::NCHW && dataFormat() == DataFormat::NCHW)) {
+            mDataFormat = df;
+            return;
+        }
+    
+        const auto transpose = getDataFormatTranspose(dataFormat(), df);
+        
+        if (mImpl) {
+            copyTranspose(*this, transpose);
+        } else {
+            std::vector<DimSize_t> newDims;
+            for (std::size_t i = 0; i < dims().size(); ++i) {
+                newDims.push_back(dims()[transpose[i]]);
+            }
+    
+            std::vector<std::size_t> newStrides(dims().size(), 1);
+            for (size_t i = 0; i < dims().size(); ++i) {
+                for (size_t j = i + 1; j < dims().size(); ++j) {
+                    newStrides[i] *= newDims[j];
+                }
+            }
+            mDims = std::move(newDims);
+            mStrides = std::move(newStrides);
+        }
+    
         mDataFormat = df;
     }
-
     /**
      * @brief Get the Impl object
      * @return constexpr const std::shared_ptr<TensorImpl>&

[Olivier BICHLER]

Seems redundant with the first if (line 465). This code will never be executed.

[Wissam Boussella]

fixed in last commit