fix failed onnx tests
Context
This MR is intended to fix the failed onnx tests encountered in issue aidge_onnx#50 and issue aidge_onnx#46.
This includes the following problems:
- Flatten: missing python binding.
- And/Equal: A mistake was made, the operator Equal was named And.
- AvgPooling: unsupported attrs
dilations
andceil_mode
- MaxPooling: unsupported attr
dilations
Detailed major modifications
The following modifications were made:
- Add python binding for flatten
- Add Equal operator
- Add dilations attr to Maxpooling
- Add
dilations
andceil_mode
to AvgPooling
TODO
This MR would only fix the following:
-
Add Flatten binding -
Add Equal Op -
AvgPooling: add dilations
andceil_mode
attrs -
MaxPooling: add dilations
attr
Merge request reports
Activity
added 58 commits
-
489d7d8f...c8cd6510 - 56 commits from branch
dev
- 3ed9cd69 - Add python binding for Flatten
- 65fe3a64 - add Equal operator
-
489d7d8f...c8cd6510 - 56 commits from branch
@olivierbichler @pineapple for Sum operator it is the Add operator with input_nbr and since we removed nbr_inputs attr from Add, the Sum operator is no longer supported.
SO should I put back the nbr_inputs to Add or should I create a new operator Sum that is basically the old version of Add?
As for Pad, it is impossible to support fully the operator and keep the template because for newer versions of the operator, the DIM value is not available at import time (secondary inputpads
isNone
).Edited by Houssem ROUISI propose to address these issues in a separate MR. My suggestions:
- I agree that Add should be just a specific case of Sum, but I think it may be interesting to still distinguish the two operators. Perhaps Add could inherit from Sum? Not sure it is the best idea.
- We should probably refactor to remove the template then...
added 11 commits
-
65fe3a64...28f4fecb - 8 commits from branch
dev
- 14a8772b - Add python binding for Flatten
- 27865e4f - add Equal operator
- 9e074f38 - add dilations to maxpooling
Toggle commit list-
65fe3a64...28f4fecb - 8 commits from branch
added 2 commits
added 18 commits
Toggle commit listadded 29 commits
Toggle commit listrequested review from @olivierbichler
added 11 commits
Toggle commit listenabled an automatic merge when all merge checks for 49f938e9 pass
added StatusReview Ready label and removed StatusWork in Progress label
mentioned in commit cb7ee7d5
changed milestone to %aidge v0.6.0
mentioned in merge request aidge_learning!36 (merged)
mentioned in merge request aidge_backend_cuda!71 (merged)