Add show_graphview funcionality.
Context
Adds functionality to output the description of a GraphView in a human-readable JSON format. Solves issue #160.
Added files
-
aidge_core/aidge_core/show_graphview.py
contains several auxiliary methods to translate the GraphView attributes to a Python dictionary and output the JSON file. -
aidge_core/aidge_core/unit_tests/test_show_graphview.py
contains tests to verify that the attributes of the generated JSON correspond to the original GraphView.
Merge request reports
Activity
assigned to @idealbuq
requested review from @gregkub
requested review from @cmoineau
- Resolved by Iryna DE ALBUQUERQUE SILVA
added 3 commits
-
caf7a77e...ad54c96a - 2 commits from branch
eclipse/aidge:dev
- 352e8733 - Merge remote-tracking branch 'origin/dev' into dev
-
caf7a77e...ad54c96a - 2 commits from branch
- Resolved by Iryna DE ALBUQUERQUE SILVA
- Resolved by Iryna DE ALBUQUERQUE SILVA
- Resolved by Iryna DE ALBUQUERQUE SILVA
- Resolved by Iryna DE ALBUQUERQUE SILVA
- Resolved by Iryna DE ALBUQUERQUE SILVA
- Resolved by Iryna DE ALBUQUERQUE SILVA
- Resolved by Iryna DE ALBUQUERQUE SILVA
- Resolved by Iryna DE ALBUQUERQUE SILVA
- Resolved by Iryna DE ALBUQUERQUE SILVA
Overall the MR looks good to me.
I request some changes, especially the use of !202 (merged).
A little extra point, I saw that you created a very modular structure for your function which eased the review ! In Python the convetion is to prepend with
_
functions/members that shouldn't be used outside of the module. This is very minor and I don't even apply it everywhere but function such as:write_dict_json
andcreate_dict
could be explicitly marked as not to use directly.added 1 commit
- d2368727 - Added minor corrections required in MR 211 review
added 1 commit
- 4efb98f2 - Removed commented out lines in python_binding/data/pybind_Data.cpp