Skip to content
Snippets Groups Projects

Add show_graphview funcionality.

Merged Iryna DE ALBUQUERQUE SILVA requested to merge idealbuq/aidge_core:dev into dev

Context

Adds functionality to output the description of a GraphView in a human-readable JSON format. Solves issue #160.

Added files

  • aidge_core/aidge_core/show_graphview.py contains several auxiliary methods to translate the GraphView attributes to a Python dictionary and output the JSON file.
  • aidge_core/aidge_core/unit_tests/test_show_graphview.py contains tests to verify that the attributes of the generated JSON correspond to the original GraphView.

@cmoineau @gregkub

Edited by Iryna DE ALBUQUERQUE SILVA

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 3 commits

    Compare with previous version

  • added 1 commit

    • ba3e7701 - Corrected typehints in show_graphview.py

    Compare with previous version

  • Cyril Moineau
  • Cyril Moineau
  • Overall the MR looks good to me.

    I request some changes, especially the use of !202 (merged).

    A little extra point, I saw that you created a very modular structure for your function which eased the review ! In Python the convetion is to prepend with _ functions/members that shouldn't be used outside of the module. This is very minor and I don't even apply it everywhere but function such as: write_dict_json and create_dict could be explicitly marked as not to use directly.

  • Cyril Moineau requested changes

    requested changes

  • added 1 commit

    • d2368727 - Added minor corrections required in MR 211 review

    Compare with previous version

  • added 1 commit

    • 4efb98f2 - Removed commented out lines in python_binding/data/pybind_Data.cpp

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading