[Add] Clip Operator
-Added tensors of empty shape to represent min and max attributes.
-ForwardDims can now copy min and max tensors into the attributes. In case of conflicts, the data inside the tensors takes precedence over the class attributes.
-Created unit test cases to validate this behavior.
-Implemented Python bindings for the class.
See Issue:aidge_quantization#38 (closed)
Main difference with !190 (closed): Changing Min and Max Attributes into OptionalData inputs to make the Operator compatible with ONNX
Add Clip Operator
Merge request reports
Activity
@gregkub Can you please review this MR!
requested review from @gregkub
assigned to @noamzerah
added 44 commits
-
65db3fa2...0a40c485 - 42 commits from branch
eclipse/aidge:dev
- d9f4aac9 - Merge branch 'dev' of https://gitlab.eclipse.org/eclipse/aidge/aidge_core into...
- b364ab11 - Fix Clip operator after Registar Refactoriaztion
-
65db3fa2...0a40c485 - 42 commits from branch
added 1 commit
- c2cd4f0c - Adding optional attributes min and max for Clip operator
requested review from @hrouis
mentioned in merge request !190 (closed)
added Feature 🚀 StatusReview Ready TopicOperator labels
- Resolved by Noam Zerah
This MR needs to be rebased locally @noamzerah. Can you do it?
added 42 commits
-
c2cd4f0c...2767bec3 - 41 commits from branch
eclipse/aidge:dev
- 63a8508c - Merge branch 'dev' of https://gitlab.eclipse.org/eclipse/aidge/aidge_core into...
-
c2cd4f0c...2767bec3 - 41 commits from branch
- Resolved by Maxence Naud
@noamzerah Just like the onnx merge request, could you select "squash commit" & give a more meaningful name to the merge request ?
It seems you talk about extending support because you are based on a previous merge request that was closed but I would be better to simply state what you do in the merge request : You add a new clipping node.
Could you also do that for the backend_cpu merge request?
Edited by Grégoire Kubler