Skip to content
Snippets Groups Projects

[Add] Clip Operator

Merged Noam Zerah requested to merge noamzerah/aidge_core:clipping_node_remove_attr into dev

-Added tensors of empty shape to represent min and max attributes.

-ForwardDims can now copy min and max tensors into the attributes. In case of conflicts, the data inside the tensors takes precedence over the class attributes.

-Created unit test cases to validate this behavior.

-Implemented Python bindings for the class.

See Issue:aidge_quantization#38 (closed)

Main difference with !190 (closed): Changing Min and Max Attributes into OptionalData inputs to make the Operator compatible with ONNX

Add Clip Operator

Edited by Noam Zerah

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @noamzerah Just like the onnx merge request, could you select "squash commit" & give a more meaningful name to the merge request ?

    It seems you talk about extending support because you are based on a previous merge request that was closed but I would be better to simply state what you do in the merge request : You add a new clipping node.

    Could you also do that for the backend_cpu merge request?

    Edited by Grégoire Kubler
  • Noam Zerah changed title from Clipping Nodes Refactorization to Clipping Nodes adding min and max as Input

    changed title from Clipping Nodes Refactorization to Clipping Nodes adding min and max as Input

  • Noam Zerah changed title from Clipping Nodes adding min and max as Input to Clipping Nodes adding min and max as nput

    changed title from Clipping Nodes adding min and max as Input to Clipping Nodes adding min and max as nput

  • Noam Zerah changed title from Clipping Nodes adding min and max as nput to Clipping Nodes adding min and max as input

    changed title from Clipping Nodes adding min and max as nput to Clipping Nodes adding min and max as input

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading