Complete Aidge Core support for Scalar Tensors by disambiguating between undefined rank/dims and scalar.
The proposed change is to add a Tensor::undefined() method to disambiguate Tensors which have not been assigned dimensions yet from empty() Tensors which have empty dimensions.
The choice have been made to keep the previous implementation of Tensor::empty() as is for backward compatibility.
I.e.:
It implies that:
Changes have been done in the first commit to:
Changes have been done in the second commit to augment tests for scalar use cases:
The change should be backward compatible.
When running unit tests several times in aidge_core (before my changes), I never get the same number XXX in the test output "XXX assertions in 76 tests cases". For instance running it twice:
build/unit_tests/tests_aidge_core --rng-seed 1 --out all_tests.txt
build/unit_tests/tests_aidge_core --rng-seed 1 --out all_tests_2.txt
And comparing outputs:
diff all_tests.txt all_tests_2.txt
< All tests passed (47742 assertions in 76 test cases)
---
> All tests passed (43928 assertions in 76 test cases)
Is it known? Do you have a method to actually get the full count of tested assertions or use case?
Copyright © Eclipse Foundation, Inc. All Rights Reserved. Privacy Policy | Terms of Use | Copyright Agent