Unified interface for attributes
In this MR, I propose a more unified attributes handling.
Refactor
- Use the term "attribute" instead of "parameter"
- Uniformized function naming ("hasAttr" and "getAttr" + "addAttr"/"setAttr"/"delAttr" for DynamicAttributes)
- Parametrizable -> StaticAttributes
- CParameter -> DynamicAttributes
- Adding abstract class
Attributesto uniformize Dynamic & StaticAttributes
Also
- Includes fix for bug #8 (closed) (as it may get lost in MR !9 (merged))
- Distinguish between "addAttr" (asserts if already exists) and "setAttr" (do not care if already exists)
- "Universal" Python binding for DynamicAttributes
- Added AIDGE_THROW_OR_ABORT macro
Merge request reports
Activity
requested review from @pineapple and @cmoineau
assigned to @olivierbichler
added 24 commits
-
5aa49ccf...a0c3eb14 - 23 commits from branch
main - d0345bba - Merged with main
-
5aa49ccf...a0c3eb14 - 23 commits from branch
mentioned in merge request aidge_backend_cpu!10 (closed)
added 2 commits
added 1 commit
Ready to be merged! @cmoineau @pineapple
changed milestone to %v0.1.0
Resolved by Olivier BICHLERI think we should update the MR description to reflect all the changes done;
This will be specially helpfull for the Changelog.
Other than that, I think the MR is good !
- Last reply by Cyril Moineau
- Resolved by Olivier BICHLER
@olivierbichler, @pineapple, @vtemplier
What do you think of taking the opportunity of this MR to rename Parameters -> Attributes.
Indeed, Parameters can be confusing with Learnable parameters ?
With the name DynamicParameters and StaticParameters I feel like the distinction is clearer, thoguhts ?
- Last reply by Olivier BICHLER
