Fix Reshape
Context
Fix Reshape operator:
- Handle case where a dimension is 0 (see ONNX)
- Support both cases where the shape is either an input or an attribute
Modified files
-
Reshape.hpp
,Reshape.cpp
, andpybind_Reshape.cpp
;
Merge request reports
Activity
Filter activity
@pineapple can you test this fix and tell me if it solves your problem?
- Resolved by Houssem ROUIS
assigned to @hrouis
requested review from @pineapple
added 47 commits
-
98e9bc5c...d0790356 - 46 commits from branch
eclipse/aidge:dev
- 0491d9fc - Merge branch 'dev' of gitlab.eclipse.org:eclipse/aidge/aidge_core into fix_reshape
-
98e9bc5c...d0790356 - 46 commits from branch
mentioned in issue #118 (closed)
added 21 commits
-
3363cf0f...1a0d54d5 - 15 commits from branch
eclipse/aidge:dev
- 7df87c11 - fix computeOutputDims
- 223d18b5 - support input and/or attribute for reshape
- d4917132 - clear shape attr before copying input
- 0fef5757 - fix ReshapeImpl test
- e1d961d9 - added test for both shape initializations
- fc39b17a - avoid connecting empty shape tensor
Toggle commit list-
3363cf0f...1a0d54d5 - 15 commits from branch
enabled an automatic merge when the pipeline for fc39b17a succeeds
mentioned in issue #108 (closed)
changed milestone to %aidge - May 2024
added Feature label
added Fix 🔥🔥 TopicOperator labels and removed Feature label
Please register or sign in to reply