[OperatorImpl] Too much virtual function ?

Hello,

This issue is linked to !19 (merged).

After binding OperatorImpl, I do think this class has too much methods:

https://gitlab.eclipse.org/eclipse/aidge/aidge_core/-/blob/26dd3e27e6ff0e232d12af41946b281d42471df9/python_binding/backend/pybind_OperatorImpl.cpp#L110-117

This is especially due to all the methods added to satisfy the consummer producer scheduling.

Can't we reduce the number of method to override to create an OperatorImpl ?

assigned to @olivierbichler and @pineapple

added 1 deleted label

Actually, I had exactly the same reflexion! I was thinking of providing a default implementation for all the memory/producer-consommer model. The issue is, the size of input and output tensors needs to be known, which is not the case right now in OperatorImpl.

Yes, furhtermore, OperatorImpl does not have a reference to an Operator. We only add the reference on the specialization of OperatorImpl such as FCImpl. While this would force cast everywhere, shouldn't we add a std::shared_ptr<Operator> attribute to OperatorImpl ?

@pineapple Do you have any suggestion on the matter ?

mentioned in issue #38 (closed)

Will be handled by: !37 (merged)

Closing this issue following !37 (merged).

closed