Comparing Networks Layer by layer

See #226 (comment 2954598)

added Discussion 💬 label

A script was created to do this here: https://gitlab.eclipse.org/eclipse/aidge/aidge_onnx/-/blob/main/aidge_onnx/unit_tests/compare_layers_aidge_onnx.py?ref_type=heads

However afaik the script is not up to date ? (@hrouis, @gregkub can yo confirm?)

When I discussed this with @gregkub, he said we cannot update the script because it is based on comparing nodes outputs given the name of the node but now it is no longer possible since we can no longer get the Aidge node from the name given in the ONNX.
Correct me if I am wrong.

Ok so a big refactor would be necessary ...

Thanks for the answer

No problem! We need to keep the same name as ONNX nodes or apply an easily reversible modification when creating Aidge node.

Name is not mandatory for ONNX node so this is why we don't use them.

I think we can use this function: https://gitlab.eclipse.org/eclipse/aidge/aidge_onnx/-/blob/main/aidge_onnx/utils.py?ref_type=heads#L21 to transform the names of the ONNX graph and then compare with Aidge. Actually this may fix the problem pretty quickly

I can assign myself to fix this and possibly add the script has a command line like:

python -m aidge_onnx.test mymodel.onnx --input-shape data_322:1,3,270,480 --nb_test 10 --rprec 0.01 --aprec 0.001

Hi, I added related issues so you can know what we talked about before :)

marked this issue as related to aidge_onnx#32

marked this issue as related to aidge_onnx#11