const char* should be removed in favor of string

In Tensor, setBackend is expecting an std::string which is passed to the create() function. In TensorImpl, the Backend is passed as a mere pointer to char which might go dangling if the corresponding used string is not permanent.

if std::string is allowed, shouldn't it be used everywhere to guarantee correct memory management? Otherwise, char const * based signatures will probably lead to runtime errors.

TODO:

• Operators name
• Operators type
• Operator attributes
• Data mType

@pineapple If I remember correctly we decided to use string everywhere no ?

there are still const char * around.

They are generally set to static char arrays but nothing is preventing for a bad client usage that will lead to dangling pointers.

I agree, we should use string. I already did the change for the name of the operators, which was actually causing issue, with plain wrong result with MSVC! Meaning something was clearly wrong somewhere with const char*!

changed title from string management and consistency to String management and consistency

changed the description

added 1 deleted label

assigned to @pineapple

changed milestone to %v0.1.0

mentioned in merge request !11 (merged)

mentioned in merge request !8 (merged)

changed title from String management and consistency to {+const char should be removed in favor of string+}*

added PriorityMedium + 1 deleted label

mentioned in commit 8949651e

mentioned in merge request !53 (merged)

Change done for operator types in !53 (merged)

changed the description

marked the checklist item Operators name as completed

marked the checklist item Operators type as completed

mentioned in merge request !57 (merged)

Done in MR !77 (merged).