Skip to content
Snippets Groups Projects
Commit bfa7580b authored by Olivier BICHLER's avatar Olivier BICHLER
Browse files

Removed [[deprecated]] but changed the name accordingly for the CI to pass

parent 24cf3e0a
No related branches found
No related tags found
1 merge request!53GraphView inputs/outputs ordering
Pipeline #35190 failed
......@@ -454,7 +454,7 @@ protected:
* This function DOES NOT preserve inputs/outputs order and should NOT BE USED.
* It is here only to leave time to adapt the replace() function.
*/
[[deprecated]] void updateInputsOutputsNodes();
void updateInputsOutputsNodes_DEPRECATED();
private:
///////////////////////////////////////////////////////
......
......@@ -807,7 +807,7 @@ bool Aidge::GraphView::replace(const std::set<Aidge::NodePtr>& oldNodes, const s
graphPtr->add(newNodes, false);
if (newNodes.empty()) {
// TODO: FIXME: this function should not be called anymore!
graphPtr->updateInputsOutputsNodes();
graphPtr->updateInputsOutputsNodes_DEPRECATED();
}
}
......@@ -1028,7 +1028,7 @@ void Aidge::GraphView::updateInputsOutputsDelete(std::shared_ptr<Node> deletedNo
}
}
void Aidge::GraphView::updateInputsOutputsNodes() {
void Aidge::GraphView::updateInputsOutputsNodes_DEPRECATED() {
mInputNodes.clear();
for (const std::shared_ptr<Node>& go_ptr : mNodes) {
IOIndex_t inputIdx = 0;
......
......@@ -35,8 +35,8 @@ public:
// ctor
}
void updateInputsOutputsNodes_Test() {
GraphView::updateInputsOutputsNodes();
void updateInputsOutputsNodes_DEPRECATED_Test() {
GraphView::updateInputsOutputsNodes_DEPRECATED();
}
};
......@@ -68,7 +68,7 @@ TEST_CASE("genRandomDAG") {
++nbUnicity;
// Test deprecated function
g1->updateInputsOutputsNodes_Test();
g1->updateInputsOutputsNodes_DEPRECATED_Test();
// Check that inputs/outputs are the same regardless of the order
auto orderedInputs1 = nodePtrTo(g1->getOrderedInputs(), nodePtrToName);
auto orderedInputs2 = nodePtrTo(g2->getOrderedInputs(), nodePtrToName);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment