Skip to content
Snippets Groups Projects
Commit a1602db8 authored by Grégoire Kubler's avatar Grégoire Kubler
Browse files

fix : in the end we need this python dep

parent ce8e73ce
No related branches found
No related tags found
2 merge requests!212Version 0.3.0,!116feat/release_pip
Pipeline #45509 canceled
......@@ -87,10 +87,11 @@ if (PYBIND)
# Handles Python + pybind11 headers dependencies
target_link_libraries(${module_name}
PRIVATE
Python::Module
Python::Python
PUBLIC
pybind11::pybind11
)
target_link_libraries(${project} PUBLIC ${module_name})
endif()
target_link_libraries(${module_name} PUBLIC Threads::Threads fmt::fmt)
......
......@@ -4,7 +4,7 @@ macro(generate_python_binding )
# Use the New FindPython mode, recommanded. Requires CMake 3.15+
find_package(Python 3.7.0
COMPONENTS Interpreter Development.Module
COMPONENTS Interpreter Development.Module Development.Embed
REQUIRED)
set(PYBIND11_FINDPYTHON ON)
set(PYBIND_VERSION v2.10.4)
......@@ -21,7 +21,6 @@ macro(generate_python_binding )
pybind11_add_module(${project} MODULE ${pybind_src_files} "NO_EXTRAS") # NO EXTRA required for pip install
target_include_directories(${project} PUBLIC "python_binding" ${pybind11_INCLUDE_DIRECTORIES})
target_link_libraries(${project} PUBLIC ${module_name})
endmacro()
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment