Change tensorimpl opencv `future_std::span<cv::Mat>` to `cv::Mat`
Why ?
TensorImpl_opencv attribute future_std::span<cv::Mat> mData;
is not relevant.
MR Content :
-
Change to cv::Mat mData;
-
Adapt functions of TensorImpl_opencv -
Adapt tests -
Change the opencv::imread
flag fromIMREAD_COLOR
toIMREAD_UNCHANGED
and adpat tests. The flagIMREAD_COLOR
was always loading 3 channels, even for grayscale images whileIMREAD_UNCHANGED
adapts to the input file. See : https://docs.opencv.org/4.x/d8/d6a/group__imgcodecs__flags.html#ga61d9b0126a3e57d9277ac48327799c80
Implement the solution presented in issue #3 (closed).
-
Change the constructor of TensorImpl to take the dimensions of the tensor as argument instead of the number of elements. For tensorImpl_opencv : - Add mDims attribute in the class to use in Lazy_init (Instanciation of cv::Mat)
- Override the resize function from TensorImpl.hpp to update mDims
Merge request reports
Activity
changed milestone to %aidge_backend_opencv - v0.1.0
requested review from @olivierbichler and @pineapple
assigned to @thibaultallenet
changed title from Change tensorimpl opencv future_std::spancv::Mat to cv::Mat to Change tensorimpl opencv {+
+}future_std::span<cv::Mat>{+
+} to {++}cv::Mat{+*
+}changed milestone to %aidge_backend_opencv - v0.0.2
added LanguageC++ label
added 1 commit
- a5f42002 - Change TensorImpl to store a cv::Mat & update tests accordingly
added 1 commit
- c64f1a31 - Change opencv imread flag to IMREAD_UNCHANGED
marked the checklist item Change the
opencv::imread
flag fromIMREAD_COLOR
toIMREAD_UNCHANGED
and adpat tests. The flagIMREAD_COLOR
was always loading 3 channels, even for grayscale images whileIMREAD_UNCHANGED
adapts to the input file. See : https://docs.opencv.org/4.x/d8/d6a/group__imgcodecs__flags.html#ga61d9b0126a3e57d9277ac48327799c80 as completedadded 15 commits
-
c64f1a31...2bc94a09 - 12 commits from branch
dev
- ce2fe8c7 - merge rework_code into TensorImpl
- fca0a230 - Update TensorImpl constructor to take the tensor dimensions instead of the...
- d627b1d8 - Merge branch 'dev' into TensorImpl
Toggle commit list-
c64f1a31...2bc94a09 - 12 commits from branch
added 1 commit
- 1e3ce9e5 - Update colorFlag of cv::imread to UNCHANGED and fix tests on cv::Mat size.