Allowing for all-major

Context

Impossible to install without a NVIDIA board. (Issue "11": #48 (moved) )

It seems that on line 83 of the CMakeLists.txt there is CMAKE_CUDA_ARCHITECURE instead of CMAKE_CUDA_ARCHITECTURES. Despite setting environment variable to "all-major", the passed argument to cmake is -DCMAKE_CUDA_ARCHITECTURES=native. Indeed the compilation option 'native' is forced by line 93 of setup.py.

Modified files

• CMakeLists.txt, orthographic correction + addition of a default CUDA compiler version;
• setup.py, getting CMAKE_CUDA_ARCHITECTURES from the environment and passing it to cmake.

Detailed major modifications

(Explain the non-trivial changes you made in the modified files)

(Specify if you made an important technical decision which should be added to the wiki https://gitlab.eclipse.org/groups/eclipse/aidge/-/wikis/home or the documentation)

TODO

(List the changes that need to be done to track the progress of the MR, you need to update the list when committing !)

• NOT DONE
• DONE - Don't understand which changes should be done.
• TO DO

mentioned in issue #48 (moved)

added Compilation ⚙ Fix 🔥🔥 StatusWork in Progress labels

resolved all threads

added 1 commit

• 51b629fc - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

added 10 commits

• 51b629fc...b488c7cd - 6 commits from branch eclipse/aidge:dev
• 801c2cd4 - Ortograph ARCHITECTURE
• cb4e0b23 - ARCHITECTURES with S eveywere
• 9511e7c5 - Passing architectures from python setup and setting a default CUDA compiler version
• 3190a0b9 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

enabled an automatic merge when all merge checks for 3190a0b9 pass

Looking at the error it looks like you compile 12.8 but the ci run with 12.8. I changed the default version :)

Ok looking at CMake documentation https://cmake.org/cmake/help/latest/prop_tgt/CUDA_ARCHITECTURES.html#cuda-architectures native was added in CMAKE 3.24.

@olivierbichler is it a change we want to make?

Most recent distros have at least 3.25, with the notable exception of Ubuntu 22.04: check https://pkgs.org/download/cmake. So the question is: do we still have 22.04 on our own servers?

Normally no but this version is supported until 2027.

We can add the dependency in the python package which will install Cmake 3.24. This will not work for user that directly compile without using pip.

Ok for me.

aborted the automatic merge because target branch was updated

I there something I have to w.r.t. this merge request?

mentioned in commit d426b431

added 1 commit

• d426b431 - Update minimal cmake to 3.24, see...

Compare with previous version

mentioned in commit farges/trying_all-major@b4dc0722

added 110 commits

• d426b431...42e0de88 - 105 commits from branch eclipse/aidge:dev
• 79460129 - Ortograph ARCHITECTURE
• 98c39a3b - ARCHITECTURES with S eveywere
• d5718bcc - Passing architectures from python setup and setting a default CUDA compiler version
• 53475cfb - Apply 1 suggestion(s) to 1 file(s)
• b4dc0722 - Update minimal cmake to 3.24, see...

Compare with previous version

enabled an automatic merge when all merge checks for b4dc0722 pass

changed milestone to %aidge v0.9.0

assigned to @farges

requested review from @cmoineau

I updated the CMakeLists to use Cmake 3.24 as discussed. I run the pipeline and set this MR to auto merge.

canceled the automatic merge

enabled an automatic merge when all merge checks for b4dc0722 pass

Arf as expected only the python pipeline is working the C++ ones don't see the new dep and uses CMake 3.22 which is not compatible...

Need to install CMAke 3.24 in the CI especially since Ubunut 22.04 will not be supported in 6 months.

left review comments

aborted the automatic merge because target branch was updated

There is an upcoming refactor of the build systems (both for C++ and python). This will let you override CMAKE_CUDA_ARCHITECTURES from the command line (or a preset, whichever suits you best). This should land shortly after switching to the mono repo.

Since we need to close MRs before switching to the mono repo, this MR will be closed !

Ok, thanks @farges, @tblauwe, lets close this as a refactor will come shortly.

closed