Skip to content
Snippets Groups Projects

Learning Metrics operators support

All threads resolved!

Context

To Support Adam Optimizer, this MR adds operator Sqrt's forward implementation. It also fixes ReduceMean and ReduceSum in case no reduction is needed (encountered in BCE and MSE unit tests)

Modified files

  • SqrtImpl.hpp, SqrtImpl.cpp, SqrtImpl_CUDA_kernels.hpp, SqrtImpl_CUDA_kernels.cu and Test_SqrtImpl.cpp, add Sqrt forward and backward operation;
  • ReduceMeanImpl.cpp, fix ReduceMean forward;
  • ReduceSumImpl.cpp, fix ReduceSum forward;

TODO

  • Add Sqrt
  • Fix ReduceMean
  • Fix ReduceSum
Edited by Houssem ROUIS

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Cyril Moineau
  • Houssem ROUIS added 5 commits

    added 5 commits

    • 85fc4d90...325360b5 - 3 commits from branch eclipse/aidge:dev
    • b59092cb - Merge branch 'dev' of gitlab.eclipse.org:eclipse/aidge/aidge_backend_cuda into...
    • b05fa723 - remove Sqrt backward random tests

    Compare with previous version

  • Cyril Moineau
  • Cyril Moineau requested review from @cmoineau

    requested review from @cmoineau

  • Houssem ROUIS added 1 commit

    added 1 commit

    • 5df623a9 - use intrinsic functions for Sqrt kernel

    Compare with previous version

  • Houssem ROUIS resolved all threads

    resolved all threads

  • Houssem ROUIS added 1 commit

    added 1 commit

    • d223e48a - use intrinsic functions for Sqrt kernel

    Compare with previous version

  • Houssem ROUIS added 1 commit

    added 1 commit

    • ab4f440e - use intrinsic functions for Sqrt kernel

    Compare with previous version

  • Houssem ROUIS changed the description

    changed the description

  • Houssem ROUIS resolved all threads

    resolved all threads

  • Houssem ROUIS mentioned in commit 9d8dcd08

    mentioned in commit 9d8dcd08

  • merged

  • Please register or sign in to reply
    Loading