Skip to content
Snippets Groups Projects

fix failed onnx tests

Merged Houssem ROUIS requested to merge fix_operators into dev
All threads resolved!

Context

This MR is intended to fix the failed onnx tests encountered in issue aidge_onnx#50 (closed) and issue aidge_onnx#46.

This includes the following problems:

  • And/Equal: A mistake was made, the operator Equal was named And.
  • AvgPooling: unsupported attrs dilations and ceil_mode
  • MaxPooling: unsupported attr dilations

Detailed major modifications

The following modifications were made:

  • Add Equal operator
  • Fix And operator
  • Add dilations attr to Maxpooling
  • Add dilations and ceil_mode to AvgPooling

TODO

  • Add Equal Op
  • Fix And Op
  • AvgPooling: add dilations, ceil_mode attrs
  • MaxPooling: add dilationsattr
Edited by Houssem ROUIS

Merge request reports

Merge request pipeline #65864 passed

Merge request pipeline passed for f3de3e10

Approval is optional

Merged by Olivier BICHLEROlivier BICHLER 3 months ago (Feb 20, 2025 12:47pm UTC)

Merge details

  • Changes merged into dev with ab8dd8d8.
  • Deleted the source branch.

Pipeline #66369 waiting for manual action

Pipeline waiting for manual action for ab8dd8d8 on dev

Test coverage 83.80% from 0 jobs

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading