Implementation of Max Pool in cpp
1 unresolved thread
1 unresolved thread
There is a Max Pool implementation with its unit test.
Merge request reports
Activity
Filter activity
requested review from @cmoineau
assigned to @ikucher
69 const std::size_t syMin = static_cast<std::size_t>(std::max(dify, signedsize(0))); 70 const std::size_t syMax = (static_cast<signedsize>(dims[3]) + dify) < 0 ? 0 : ((dims[3] + dify) > std::get<1>(params)[1] ? std::get<1>(params)[1] : dims[3] + dify); 71 const std::size_t oIndexFull = oIndex + ox*oySize + oy; 72 const std::size_t ix = ox * std::get<0>(params)[0]; 73 const std::size_t iy = oy * std::get<0>(params)[1]; 74 75 I poolValue(0.0); 76 77 for (unsigned int channel = 0; channel < dims[1]; 78 ++channel){ 79 for (unsigned int sy = syMin; sy < syMax; ++sy) { 80 for (unsigned int sx = sxMin; sx < sxMax; ++sx) 81 { 82 const I value = input[iIndex + (ix+sx)*dims[3] + (iy+sy)]; 83 84 if (!valid || value > poolValue) { Hello @ikucher, here the variable
valid
is not defined ! Looks like you may have some uncommited files ;)FYI, I have begun a merge with the master branch, I will take care of conflicts and merge process, can you please just commit all your local changes so that I can make your test pass ?
Thanks in advance ! :D
The declaration was missing :
bool valid = false;
This is fixed in commit : 99b67d87
Edited by Inna Kucher
added 28 commits
-
bbb02de4...039f265a - 24 commits from branch
master
- 9bab0a91 - Merge branch 'master' into maxPoolImplem
- b2107a2f - Merge branch 'maxPoolImplem' of...
- 4507c66d - Merge branch 'maxPoolImplem' of...
- 6308e639 - [MaxPooling] Adapt MaxPoolImpl to latest change on attributes.
Toggle commit list-
bbb02de4...039f265a - 24 commits from branch
enabled an automatic merge when the pipeline for 6308e639 succeeds
mentioned in commit 8c5764b4
Please register or sign in to reply