Skip to content

Missing ``dilation`` parameter in Conv[DepthWise] forward kernel

Required prerequisites

  • Make sure you've read the documentation. Your issue may be addressed there.
  • Search the issue tracker and discussions to verify that this hasn't already been reported. +1 or comment there if it has.

What commit version of aidge do you use

  • aidge_core: 0.3.0
  • aidge_backend_cpu: 0.3.0

Problem description

dilation parameter not used by the Convolution kernel forward operation.

Not only is it a missing feature, but it can also lead to segmentation fault errors, accessing memory out of the scope.

Here is an extract of the Conv1D forward kernel. We can clearly see the dilation parameter is commented

template <class I, class W, class B, class O>
void ConvImpl1D_cpu_forward_kernel(const std::array<DimSize_t, 1>& strideDims,
                            const std::array<DimSize_t, 1>& /*dilationDims*/,
                            const std::array<DimSize_t, 1>& kernelDims,
                            const std::array<DimSize_t, 3>& inputDims,
                            DimSize_t outChannels,
                            const void *input_,
                            const void *weights_,
                            const void *biases_,
                            void *output_)
{

Solution

Add this feature for Conv and ConvDepthWise forward kernels.