Skip to content

Draft: Core/fix/shape op: documentation and onnx compatibility should take into account "end" attribute

Lucas Lopez requested to merge core/fix/shapeOp into main

Context

Shape_Op's "end" attribute is The ending index (exclusive) for the shape slice but currently this is not the case. the end index is included in Shape's output.

This may also be tied to the XFail unit tests in the onnx module.

This bug and it's solution were found by @BAUDOIN_Jean_Philippe.

Update: the original Aidge Shape implementation will be used, the end attribute will remain inclusive. But the documentation and import/export of the onnx node will be updated.

Modified files

  • Shape.hpp Small comment modifications exclusive->inclusive;
  • Shape.py import and export corrections
  • test_onnx_nodes_import_forcard.py removed XFAIL tag from some tests
Edited by Lucas Lopez

Merge request reports

Loading