Skip to content
Snippets Groups Projects
Commit ecfa861c authored by Olivier BICHLER's avatar Olivier BICHLER
Browse files

Fixed review comments

parent 1b8b0296
No related branches found
No related tags found
No related merge requests found
......@@ -273,6 +273,15 @@ public:
/**
* Get the ranked list of nodes in the GraphView.
* Node ranking if performed the following:
* - The root node is put in the ranked list first (rank 1);
* - Then, its childs (in order of outputs) are added in the ranked list;
* - Then, its parents (in order of inputs) are added in the ranked list;
* - The childs and parents of the next node in the ranked list are then
* added to the list, and so on.
* - Any remaining nodes have no path to the root node and are added in
* arbitrary order. In this case, the ranking is not garanteed to be unique.
*
* If the ranking cannot be garanteed to be unique, the second item indicates
* the rank from which unicity cannot be garanteed.
* @return std::pair<std::vector<NodePtr>, size_t> Pair with the list of ranked
......
......@@ -109,14 +109,7 @@ template <DimIdx_t DIM> void declare_PaddedMaxPoolingOp(py::module &m) {
}
void declare_LSTMOp(py::module &m) {
m.def("LSTM", [](DimSize_t in_channels,
DimSize_t hidden_channels,
DimSize_t seq_length,
bool nobias,
const std::string& name)
{
return LSTM(in_channels, hidden_channels, seq_length, nobias, name);
}, py::arg("in_channels"),
m.def("LSTM", &LSTM, py::arg("in_channels"),
py::arg("hidden_channels"),
py::arg("seq_length"),
py::arg("nobias") = false,
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment