Skip to content
Snippets Groups Projects
Commit c5157b3e authored by Eric Sandeen's avatar Eric Sandeen Committed by Greg Kroah-Hartman
Browse files

seq_file: disallow extremely large seq buffer allocations


commit 8cae8cd8 upstream.

There is no reasonable need for a buffer larger than this, and it avoids
int overflow pitfalls.

Fixes: 058504ed ("fs/seq_file: fallback to vmalloc allocation")
Suggested-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
Reported-by: default avatarQualys Security Advisory <qsa@qualys.com>
Signed-off-by: default avatarEric Sandeen <sandeen@redhat.com>
Cc: stable@kernel.org
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8be8d4ba
No related branches found
No related tags found
No related merge requests found
......@@ -28,6 +28,9 @@ static void *seq_buf_alloc(unsigned long size)
void *buf;
gfp_t gfp = GFP_KERNEL;
if (unlikely(size > MAX_RW_COUNT))
return NULL;
/*
* For high order allocations, use __GFP_NORETRY to avoid oom-killing -
* it's better to fall back to vmalloc() than to kill things. For small
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment