Skip to content
Snippets Groups Projects
Commit 39dbf77a authored by Jan Kara's avatar Jan Kara Committed by Chris Wright
Browse files

[PATCH] ext3: fix log_do_checkpoint() assertion failure


Fix possible false assertion failure in log_do_checkpoint(). We might fail
to detect that we actually made a progress when cleaning up the checkpoint
lists if we don't retry after writing something to disk. The patch was
confirmed to fix observed assertion failures for several users.

When we flushed some buffers we need to retry scanning the list.
Otherwise we can fail to detect our progress.

Signed-off-by: default avatarJan Kara <jack@suse.cz>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarChris Wright <chrisw@osdl.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 7b692080
No related branches found
No related tags found
No related merge requests found
...@@ -339,8 +339,10 @@ int log_do_checkpoint(journal_t *journal) ...@@ -339,8 +339,10 @@ int log_do_checkpoint(journal_t *journal)
} }
} while (jh != last_jh && !retry); } while (jh != last_jh && !retry);
if (batch_count) if (batch_count) {
__flush_batch(journal, bhs, &batch_count); __flush_batch(journal, bhs, &batch_count);
retry = 1;
}
/* /*
* If someone cleaned up this transaction while we slept, we're * If someone cleaned up this transaction while we slept, we're
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment