Marketplace D9 Feedback from Eric Poirier

Commons

Node revisions

• After updating a node, I'm not seeing new revisions. Not sure if its by design or not?

Listings

• External Install Button tab
  • Textareas goes beyond the container

Admin pages

• Update solution versions
  • Path exists but the menu item is missing
  • Got the following error when running the batch script:
  • 
  • There's an error in the logs that seems to be related to the batch script
• Contact Unpublished Listing Owners is missing

Note: The following admin pages are also missing but I don't think they are needed. @cguindon can you confirm?

• Update Filter Format
• Update Solutions UpdateSiteUrls
• Validate Listings Compliance
• Metrics settings

added to epic &22 (closed)

assigned to @theodoreb

added Drupal 9 priorityhigh severitynormal statetodo team:webdev labels

changed the description

marked this issue as blocking #195 (closed)

Note: The following admin pages are also missing but I don't think they are needed. @cguindon can you confirm?

• Update Filter Format

This was a one-time tool. No need to migrate.

• Update Solutions UpdateSiteUrls

I don't believe we need this anymore. I believe this was created to update sites that were on HTTP but had a valid equivalent for https defined in a spreadsheet.

• Validate Listings Compliance

This was created to unpublish nodes using HTTP in their update site. This might be something we need in the future. I don't think we need this BUT we do need to make sure that we have a validation callback that ensure that all update sites URLs are using HTTPS.

@theodoreb That's my only requirement for these 3 items. Make sure to throw a form error if someone tries to set an HTTP URL in the update site's URLs. I think we should also enforce that in our other URL fields where we ask user to input an external URL.

@cguindon how about the Contact listing owner page and metrics settings page. Should we migrate them?

Good catch - That page is useful when we need to send our communications to all listing owners. I hope it's still easy to recreate with views.

And is the metrics settings page still good?

I took a look and it does not look like something I use or need.

mentioned in issue #202 (closed)

changed the description

The requirements to close this issue would be to:

• Create the contact listing owner page
• Create a validation callback for the updatesite url field to enforce the https urls.
• Create menu item for the "Update solution versions" admin page
• Fix the error in the batch script to Update solution versions

added statewip label and removed statetodo label

Fixes are in https://gitlab.eclipse.org/eclipsefdn/it/websites/drupal/eclipsefdn/-/merge_requests/196

closed