The author has not signed-off on the contribution #38

Signed-off-by: Christopher Guindon chris.guindon@eclipse-foundation.org

Created by: mbarbero

IMO, a positive and negative unit test is required here.

@mbarbero I agree!

I created this PR to see if our existing tests were going to fail but it looks like we are not running any of our tests when a PR is submitted.

To cover this case, we would need an additional test in our test suite that checks how it handles multiple footer entries. All of our tests currently only have 1 footer line each at most

Created by: mbarbero

It does run the tests: https://github.com/EclipseFdn/git-eca-rest-api/blob/master/Jenkinsfile#L41 (the package goal runs the tests), but there is no test covering this feature good enough to detect regression or this particular use case.

Created by: mbarbero

So first thing I would recommend: write a test reproducing current issue that fails with current code. Then modify the code (probably the fix you did in this PR) until the test passes.

@mbarbero +1 I already spoke to Martin this morning about writing tests for this.

Created by mbarbero

Review: Approved