Skip to content
Snippets Groups Projects

feat: Update pagination to use reactive + various bug fixes and upgrades

Merged Zachary Sabourin requested to merge reactive-pagination-updates into main
All threads resolved!
  • feat: Update pagination to use reactive + various bug fixes and upgrades

Merge request reports

Pipeline #52843 passed

Pipeline passed for 45cdb0bb on reactive-pagination-updates

Merged by Zachary SabourinZachary Sabourin 1 year ago (Aug 13, 2024 5:29pm UTC)

Merge details

  • Changes merged into main with 4f85024d (commits were squashed).
  • Deleted the source branch.

Pipeline #52891 passed

Pipeline passed for 4f85024d on main

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Martin Lowe
  • Martin Lowe
  • Martin Lowe
  • Martin Lowe
  • Martin Lowe requested changes

    requested changes

  • added 1 commit

    • 7c179608 - feat: Integrate async pagination + update imperative pagination to use RestResponse

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    • 1e6ff03d - feat: Add testing for MockDataPaginationHandler

    Compare with previous version

  • added 1 commit

    • 45cdb0bb - feat: Convert handler to return a RestResponse + update tests to check headers

    Compare with previous version

  • Zachary Sabourin requested review from @malowe

    requested review from @malowe

  • Zachary Sabourin marked this merge request as ready

    marked this merge request as ready

  • Martin Lowe resolved all threads

    resolved all threads

  • The only question I have is did you confirm this build still handles GZIP'd content? It looks like you removed all of the GZIP properties from the property files.

  • I did! I tested this along with this patch: eclipsefdn-working-groups-api!79 (merged)

    It can be confirmed by using the GzipClientRequestFilter to enable GZIP'd content through RestClients and setting the quarkus.http.enable-compression config to false. This will cause it to fail (due to being unable to properly deserialize the GZIP content) until the config has been re-enabled.

    I removed the tests and configs for this since we no longer need to handle to decompression manually. We just need to ensure the @Compressed annotation is set on our Restclients and that quarkus.http.enable-compression is set to true.

  • Martin Lowe approved this merge request

    approved this merge request

  • Please register or sign in to reply
    Loading