[Bug 347666] Establish Checkstyle/PMD code style checks

Bugzilla Link	347666
Status	NEW
Importance	P3 normal
Reported	May 30, 2011 11:32 EDT
Modified	Sep 22, 2020 13:25 EDT
Reporter	David Carver

Description

With the implementation of bug 339915 to create an eclipse-parent pom file. We now have the ability to fairly easily have PMD or Checkstyle maven plugins to enable code quality checks during a build.

One of the things that can be difficult at times when contributing back to an open source project is making sure the source code is consitently formatted the same ways. We have many style checks that happen with JDT, but it would be nice to have an agreed upon standard across the projects at eclipse.

Projects should have the ability to override these when necessary, but in general it would help to have an established baseline that can be run and code quality reports run.

By default Checkstyle uses the Sun recommendations, however, I know the Eclipse platform has extended these. If other projects have additional requirements we should gather them together, come to an agreed upon baseline, and then setup PMD/Checkstyle to report any violations that occur.

You can then have Hudson fail the build, or make it unstable if more than a certain threshold level of warnings occur.