Please install GH hook to trigger Glassfish:HK2 Jenkins build

Summary

Please install GH hook to trigger Glassfish:HK2 Jenkins build

Steps to reproduce

Open PR in glassfish-hk2 and wait for job to be triggered manually to have status for 'continuous-integration/jenkins/...' set.

What is the current bug behavior?

It seems that job

• https://ci.eclipse.org/glassfish/job/hk2/ only processes manual triggers (Scan repository now) or at most cron'ed.

Would it be possible to trigger in on change in repository

• https://github.com/eclipse-ee4j/glassfish-hk2 please?

What is the expected correct behavior?

New PRs are discovered just as they are open, branches are processed on push.

assigned to @fgurr

A webhook was already in place, but it pointed to an old URL (jenkins.eclipse.org instead of ci.eclipse.org). It should work now. Please try again.

closed

Works fine for PR now, thank you!

@fgurr I have some other repos/jobs suspected for very similar - should I open new issues or reopen this one once I track them down?

Please reopen this one.

Please check/update hook for

• https://github.com/eclipse-ee4j/glassfish-build-maven-plugin/ https://ci.eclipse.org/glassfish/job/glassfishbuild-maven-plugin/

reopened

Fixed.

I force-pushed https://github.com/eclipse-ee4j/glassfish-build-maven-plugin/pull/53 but it didn't trigger new build...

I've updated the webhook to also send pull request events (not just push events). Please try again.

Confirmed build no. 2 started for PR-53. Thank you.

closed

Please check/update hook for

• https://ci.eclipse.org/glassfish/job/shoal/ -> https://ci.eclipse.org/glassfish/job/shoal/

reopened

added IT-prioritylow IT-severitylow ~24521 team:releng labels

Webhook was still pointing to jenkins.eclipse.org instead of ci.eclipse.org. This has been fixed.

https://ci.eclipse.org/glassfish/job/shoal/indexing/events:

[Mon Sep 26 06:07:10 EDT 2022] Received Push event to branch master in repository eclipse-ee4j/glassfish-shoal UPDATED event from 140.82.115.144 → 172.30.50.1 ⇒ https://ci.eclipse.org/glassfish/github-webhook/ with timestamp Mon Sep 26 06:07:05 EDT 2022
06:07:19 Connecting to https://api.github.com using GitHub bot (username/token)
Examining eclipse-ee4j/glassfish-shoal

  Checking branches...

  Getting remote branch master...

    Checking branch master
      ‘Jenkinsfile’ found
    Met criteria
Changes detected: master (6502258ebaeb53e23a47439e5bc0ca854dbe3e48 → db58e0de18c7711425c4ca8e0584a76fd45d0887)
Scheduled build for branch: master

  1 branches were processed (query completed)

  1 branches were processed

Finished examining eclipse-ee4j/glassfish-shoal

[Mon Sep 26 06:07:23 EDT 2022] Push event to branch master in repository eclipse-ee4j/glassfish-shoal UPDATED event from 140.82.115.144 → 172.30.50.1 ⇒ https://ci.eclipse.org/glassfish/github-webhook/ with timestamp Mon Sep 26 06:07:05 EDT 2022 processed in 12 sec

But I can't see the build being triggered for https://github.com/eclipse-ee4j/glassfish-shoal/pull/164.

closed

It was just enabled for push events. I've added pull request events.

reopened

closed

Please check/update hook for

• https://github.com/eclipse-ee4j/glassfish-woodstock https://ci.eclipse.org/glassfish/job/woodstock_build-and-test-using-jenkinsfile/

Please add pull request events.

reopened

Please check/update hook for

• https://github.com/eclipse-ee4j/glassfish-ha-api https://ci.eclipse.org/glassfish/job/ha-api/

Please add pull request events.

Done.

Thank you

closed

Please check/update hook for

• https://github.com/eclipse-ee4j/glassfish-fighterfish https://ci.eclipse.org/glassfish/job/fighterfish/

Please add pull request events.

reopened

• https://github.com/eclipse-ee4j/glassfish-fighterfish

To avoid doing this repo by repo, I've fixed it also for the following repos:

• https://github.com/eclipse-ee4j/glassfish-hk2-extra
• https://github.com/eclipse-ee4j/glassfish-cdi-porting-tck
• https://github.com/eclipse-ee4j/glassfish-copyright-plugin
• https://github.com/eclipse-ee4j/glassfish-repackaged
• https://github.com/eclipse-ee4j/glassfish-spec-version-maven-plugin
• https://github.com/eclipse-ee4j/glassfish-logging-annotation-processor

There are also a few repos, that do not have webhooks set up yet. Should I set them up?

• https://github.com/eclipse-ee4j/glassfish-security-plugin
• https://github.com/eclipse-ee4j/glassfish-maven-embedded-plugin
• https://github.com/eclipse-ee4j/glassfish-doc-plugin
• https://github.com/eclipse-ee4j/glassfish-docs
• https://github.com/eclipse-ee4j/glassfish-samples

Side question:
Is https://github.com/eclipse-ee4j/glassfish-infra still required?
It's an empty repo that has never been initialized. Creation was requested in 2019 (https://bugs.eclipse.org/bugs/show_bug.cgi?id=545503).

https://github.com/eclipse-ee4j/glassfish-fighterfish

Thanks

To avoid doing this repo by repo, I've fixed it also for the following repos:

That's great, I was only asking for the ones that I interacted/discovered. Great that it was possible for you to locate the remaining repos.

There are also a few repos, that do not have webhooks set up yet. Should I set them up?

Hmmm... Not sure. For some (glassfish-security-plugin, glassfish-maven-embedded-plugin) there are GH Actions used and probably there is no event listener set up on ci.eclipse.org. So I guess there is no need until some consuming Jenkins jobs are created.

Is https://github.com/eclipse-ee4j/glassfish-infra still required?

https://www.eclipse.org/lists/glassfish-dev/msg01384.html - once replies are collected - and I hope for 'delete it' - I'd open separate ticket - WDYT? This way - this one could be closed (probably forever!).

Hmmm... Not sure. For some (glassfish-security-plugin, glassfish-maven-embedded-plugin) there are GH Actions used and probably there is no event listener set up on ci.eclipse.org. So I guess there is no need until some consuming Jenkins jobs are created.

OK.

https://www.eclipse.org/lists/glassfish-dev/msg01384.html - once replies are collected - and I hope for 'delete it' - I'd open separate ticket - WDYT? This way - this one could be closed (probably forever!).

Sounds good.

closed

mentioned in issue #2098 (closed)

Please check/update hook for

https://github.com/eclipse-ee4j/glassfish-jsftemplating

Please add pull request events.

Done.

reopened

closed

Please check/update hook for

• https://github.com/eclipse-ee4j/orb https://ci.eclipse.org/orb/job/PR-build-and-test/
• https://github.com/eclipse-ee4j/orb-gmbal https://ci.eclipse.org/orb/job/Build%20and%20Test%20GMBAL%20PRs/
• https://github.com/eclipse-ee4j/orb-gmbal-pfl https://ci.eclipse.org/orb/job/Build%20and%20test%20PFL%20PRs/

Please add pull request events.

and for newly created job

• https://github.com/eclipse-ee4j/orb-gmbal-commons https://ci.eclipse.org/orb/job/Build%20and%20Test%20GMBAL%20Commons%20PRs/

reopened

Webhooks have been created.

Thank you,

closed