[Bug 422854] API Tooling Errors in TCF Core

Bugzilla Link	422854
Status	NEW
Importance	P3 normal
Reported	Nov 29, 2013 10:11 EDT
Modified	Dec 04, 2013 15:01 EDT
Version	1.2
Reporter	Martin Oberhuber

Description

Build ID: TCF master as of 29-Nov-2013

When I enable API Tooling on the TCF Core Plugins, I see some errors reported.
Steps to reproduce:

1. Import TCF plugins into Eclipse SDK (I used Eclipse 4.4m4 candidate)
2. Preferences > Plug-In Development > API Baselines : Set baseline
   You can download the kepler baseline that I created (platform+cdt+rse+tcf):
   http://download.eclipse.org/tools/tcf/div/tcf_kepler_api_baseline_win32.zip
3. Preferences > Plug-In Development > API Errors :
   "Set All as Error" on all tabs
4. In Project Explorer, select relevant TCF Plugins, then
   Right-click > Plug-in Tools > API Tools Setup...

When this is done, following errors show up in o.e.tcf.core , o.e.tcf.debug and o.e.tcf.debug.ui respectively:

1. TCFConsole.java : ViewPage illegally implements IPage via IPageBookViewPage
   --> Looks like it should extend org.eclipse.ui.part.Page instead
2. TCFError illegally extends DebugException
   --> Not sure how to deal with this ?
3. o.e.tcf.core : @noextend unsupported on several final classes
   --> Remove @noextend
4. o.e.tcf.core : Several @since tags missing
   --> Add missing @since tags
5. o.e.tcf.core : methods and fields added in several interfaces that are
   intended to be implemented, eg IStackTrace#getChildrenRange()
   --> I assume, that we want to mark TCF Java interfaces as @noimplement
   since they are really only meant to be an interface to the Service
   Proxies ? Otherwise, if they are intended to be implemented, we must
   be more careful.

I think we should deal with these errors, and then check-in project descriptions with API tooling enabled (similar like CDT does). Create a contributor guide that explains how to setup a workspace with API tooling (similar to http://wiki.eclipse.org/Getting_started_with_CDT_development ).