Workspace selection dialog never shows up with Sphinx plugins installed

Bugzilla Link	578205
Status	ASSIGNED
Importance	P3 normal
Reported	Jan 13, 2022 12:22 EDT
Modified	May 07, 2024 01:00 EDT
Version	0.12.0
Reporter	Raphael Weber

Description

Steps to reproduce:

1. Start a fresh installation of eclipse >=2021.06( without any sphinx plugins) - the workspace selection dialog will appear. There is a setting in Preferences -> General -> Startup and Shutdown -> Workspaces: "Prompt for workspace on startup" that can be used to always enforce the workspace selection dialog.

2. Install Sphinx plugins (tested with 0.11.2 and 0.12.0) shutdown and start eclipse again (do not use "Restart" from the File menu) - the workspace selection dialog will never show again...

3. Uninstall all Sphinx plugins and the workspace selection dialog will be back.

After some digging we found out that the new Service-Component org.eclipse.e4.ui.internal.workbench.ModelAssembler seems to be the cause. The ModelAssembler activates EMF which activates Sphinx. And Sphinx assumes the workspace to be already set (defaults to $USER_HOME\workspace), so it loads it -> workspace selection dialog can never appear.