Simplify Supplementary Sign Positioning Blocked by OSC Engine
We have a PR Request to simplify the positioning logic for supplementary sign entities. Previously, while parsing supplementary signs from OSC files was supported, positioning each supplementary sign required defining a teleport action. This approach was inconvenient, particularly when multiple supplementary signs were defined within scenarios. When no teleport action is defined, the supplementary sign's position and orientation will be overrided by the deduced position und orientation from its main sign in such a case.
The simplified positioning method for supplementary signs relies on the main sign's overridden SetPosition()
method. This method calculates the position of supplementary signs based on the main sign's orientation. Therefore, the main sign's orientation must be set first to ensure correct supplementary sign positioning.
However, currently, in the OSC engine's TeleportAction_impl
, the SetPosition()
method is invoked before SetOrientation()
, which prevents the enabling of the new functionality. A minor refactor is needed to reverse the order of these function calls.