Rename 'path separator' in entire codebase
From !403 (comment 1037743):
Path separators are for separating paths (either
;), for example the in the
From !403 (comment 1038241):
At first, I didn't understand, because I've used 'path separator' forever. I always thought of it as the separators in paths. I guess you are thinking of separators between paths, or separators that separate paths.
I'm not sure 'name separator' is very clear. What names are separated then? Googling I find no immediate hits on 'name separator'. It seems Java is actually partial to 'file separator', which produces a lot of hits, and matches with the
java.io.File.separatorfield and the 'file.separator' system property. Not really sure 'file separator' is perfect either, as both files and directories are separated by it. But the Java
Fileclass can also represent both. So at least it fits with the rest of Java.
The only problem is that I don't like changing it here. A quick search in our codebase reveals 221 matches for 'path separator'. Just changing it here will create an inconsistency, and I'm not sure that makes things more clear. I'll create a separate issue to further discuss the terminology we want, and to change it consistently in the entire codebase.