Look good to me. From my side merging is possible.
Hello, Naida sent the Individual Committer Agreement (ICA) back to the Eclipse, so everything should be fine. But she is still not listed as committer on the openPASS page. Could you please have a look on this topic? Thanks a lot and best regards Thomas
From my side, it would be ok.
@jdobberstein Please review !139 (merged) and point out if someting missing. If everything is ok, please close this issue.
One question first: Is it a problem concerning the core or is it a problem concerning the GUI?
As talked about in the last AC, we want to start the discussion about determinism in openPASS.
For BMW determinism contains several aspects:
To assess determinsim, all output files have to be considered.
Determinism is fulfilled, when the output format is exactly the same (number of decimal places, data types, enum vs. enum coding, order of all lines in the output files)
If there are known issues for example in C++ or in the number generator of the operating system, it has to be decided how we handle this problem properly.
We should define the further procedure for the year specification in the copyright header. The discussion started already in the commit 67679892: "Update copyrightHeader year".
The latest proposal is, that there are two years mentioned with comma separation: "The {year} is the year in which the content was created (e.g. “2004”). The date may optionally be set to a range of years with the first and last years of the range separated by a comma (e.g. “2004, 2017”); in this case, the first year is when the content was first created and the last year is when the content was last modified."
@all Please comment