From a313b6f3829de62b83261a239bc2ad7e839698dc Mon Sep 17 00:00:00 2001 From: Charles Villard <charles.villard@cea.fr> Date: Tue, 17 Dec 2024 16:14:00 +0100 Subject: [PATCH] edit: fmt: revert private statement as dependencies needs it too --- CMakeLists.txt | 3 +-- unit_tests/CMakeLists.txt | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index f4f296ed1..631014bc8 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -117,10 +117,9 @@ if (PYBIND) add_pybind_dependency(${module_name}) ## - target_link_libraries(${pybind_module_name} PRIVATE fmt::fmt) endif() -target_link_libraries(${module_name} PRIVATE fmt::fmt) +target_link_libraries(${module_name} PUBLIC fmt::fmt) target_link_libraries(${module_name} PUBLIC Threads::Threads) target_compile_features(${module_name} PRIVATE cxx_std_14) diff --git a/unit_tests/CMakeLists.txt b/unit_tests/CMakeLists.txt index 8257a6063..2c0c746a4 100644 --- a/unit_tests/CMakeLists.txt +++ b/unit_tests/CMakeLists.txt @@ -63,7 +63,6 @@ endif() target_link_libraries(tests${module_name} PRIVATE ${module_name}) target_link_libraries(tests${module_name} PRIVATE Catch2::Catch2WithMain) -target_link_libraries(tests${module_name} PRIVATE fmt::fmt) list(APPEND CMAKE_MODULE_PATH ${catch2_SOURCE_DIR}/extras) include(CTest) -- GitLab