From 261d904b55f541d344fa1c4747f328578b55cab1 Mon Sep 17 00:00:00 2001
From: Olivier BICHLER <olivier.bichler@cea.fr>
Date: Sun, 9 Jun 2024 13:43:21 +0200
Subject: [PATCH] Clarified behavior of forwardDims()
---
include/aidge/graph/GraphView.hpp | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/include/aidge/graph/GraphView.hpp b/include/aidge/graph/GraphView.hpp
index c9a4c11d7..627e78790 100644
--- a/include/aidge/graph/GraphView.hpp
+++ b/include/aidge/graph/GraphView.hpp
@@ -208,7 +208,12 @@ public:
/**
* @brief Compute dimensions of input/output Tensors for each Operator of the
- * GraphView object's Nodes.
+ * GraphView object's Nodes, by calling Node::forwardDims().
+ * This function verifies the following conditions:
+ * - Every node will forwardDims() regardless of if dims were previously forwarded or not;
+ * - forwadDims() calls are made in node dependencies order, because if dims have changed
+ * at any point in the graph, it must de propagated correctly to all succeeding nodes;
+ * - It handles cyclic dependencies correctly (currently only induced by the Memorize_Op).
*/
bool forwardDims(const std::vector<std::vector<DimSize_t>>& dims = {}, bool allowDataDependency = false);
--
GitLab