René Paris (10e49264) at 22 Mar 15:29
update doc
René Paris (0f055e1d) at 19 Mar 08:29
Merge branch 'v1.1.0' into 'main'
René Paris (3bd47a0d) at 19 Mar 08:29
OSI Query Library (osiql) v1.0.0
Changes:
Created an issue for this: #1
Will fix later.
Depending on compiler and version <iostream>
is a pretty heavy include.
Most uses just come from the use of an ostream
operator (see also !1 (comment 1936786)).
Replacement with <ostream>
or <iosfwd>
should be considered.
Changes:
check the while lib
do we really need the whole should suffice
Please also update the doxygen file to carry the current version number
I see no update in the README or similar files about the changed (stripped) dependencies.
Implement RelativeLateralDistanceCondition
for relativeDistanceType="lateral"
and freespace="true"
.
consider to move the implementation details into a namespace detail instead of making it a (c-style) static function.
I guess you could also get rid of "EntityUtils::" later down by doing so (but this is just a guess right now)
see e.g. TrafficSinkAction_impl.cpp for reference
I'm a little bit confused by the naming master and reference. For me reference is the entity which is taken as the origin or base of the measurement. but master seems to mean the same...
Maybe some better naming would be: "base_entity" and "target_entity"
With a complexity like that I'd like to see some doxygen in here, even if it is an implementation detail in the cpp file.
typo in less_than_comperator, but actually less_than
would suffice
if (values.coordinateSystem == CoordinateSystem::kEntity)
{
const auto& triggeringEntity = EntityUtils::GetEntityByName(mantle.environment, values.triggeringEntity);
const auto& referencedEntity = EntityUtils::GetEntityByName(mantle.environment, values.entityRef);
if (values.relativeDistanceType == RelativeDistanceType::kLongitudinal)
{
const auto distance = values.freespace
? EntityUtils::CalculateLongitudinalFreeSpaceDistance(
mantle.environment, triggeringEntity, referencedEntity)
: EntityUtils::CalculateRelativeLongitudinalDistance(
mantle.environment, triggeringEntity, referencedEntity);
return values.rule.IsSatisfied(distance.value());
}
if (values.relativeDistanceType == case RelativeDistanceType::kLateral && values.freespace)
{
cosnt auto distance = EntityUtils::CalculateLateralFreeSpaceDistance(
mantle.environment, triggeringEntity, referencedEntity);
return values.rule.IsSatisfied(distance.value());
}
}
Logger::Error("RelativeDistanceCondition: Selected relativeDistanceType or coordinateSystem not implemented yet. Only \"longitudinal\" and \"lateral\" distances and \"entity\" coordinate systems are supported for now. Returning false.");
René Paris (49f3c601) at 28 Feb 07:57
Merge branch 'setup-nightly-build' into 'develop'
... and 1 more commit