git-eca-rest-api merge requestshttps://gitlab.eclipse.org/eclipsefdn/it/api/git-eca-rest-api/-/merge_requests2023-06-15T12:49:31Zhttps://gitlab.eclipse.org/eclipsefdn/it/api/git-eca-rest-api/-/merge_requests/141Update sonar in Jenkins to split build into sonar scan and no scan build2023-06-15T12:49:31ZMartin Lowemartin.lowe@eclipse-foundation.orgUpdate sonar in Jenkins to split build into sonar scan and no scan buildhttps://gitlab.eclipse.org/eclipsefdn/it/api/git-eca-rest-api/-/merge_requests/140Iss #132 - Projects and auth token code migrations, update openapi spec2023-06-09T19:43:46ZMartin Lowemartin.lowe@eclipse-foundation.orgIss #132 - Projects and auth token code migrations, update openapi specIncludes updates to remove code that was moved to common libraries, as well as update the openapi spec to more strictly follow openapi spec guidelines.Includes updates to remove code that was moved to common libraries, as well as update the openapi spec to more strictly follow openapi spec guidelines.https://gitlab.eclipse.org/eclipsefdn/it/api/git-eca-rest-api/-/merge_requests/139Optimizing mvn calls and make targets2023-06-12T16:16:50ZFrederic Gurrfrederic.gurr@eclipse-foundation.orgOptimizing mvn calls and make targets* a separate `mvn clean` call should not be necessary (I left it in place for the setup target, in case this really make sense)
* `mvn verify` includes the `compile` and `package` phases (see Maven build lifecycle below)
* `generate-spec...* a separate `mvn clean` call should not be necessary (I left it in place for the setup target, in case this really make sense)
* `mvn verify` includes the `compile` and `package` phases (see Maven build lifecycle below)
* `generate-spec` target did point to `install-yarn` and `validate-spec` which also pointed to `install-yarn`
Maven build lifecycle: https://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html#a-build-lifecycle-is-made-up-of-phaseshttps://gitlab.eclipse.org/eclipsefdn/it/api/git-eca-rest-api/-/merge_requests/138Iss #131 - Add logic to lookup user by Github ID when available2023-06-02T14:32:22ZMartin Lowemartin.lowe@eclipse-foundation.orgIss #131 - Add logic to lookup user by Github ID when availableAn issue exists where there are inconsistencies with the email used for
commits and the associated Github user account. To patch this, a change
was made to optionally include the Github username in the validation
request. This will be us...An issue exists where there are inconsistencies with the email used for
commits and the associated Github user account. To patch this, a change
was made to optionally include the Github username in the validation
request. This will be used first when doing lookups of the user, falling
back on the default flow if not set.https://gitlab.eclipse.org/eclipsefdn/it/api/git-eca-rest-api/-/merge_requests/137Fix support for GH project org and ignored repos2023-05-31T20:05:04ZMartin Lowemartin.lowe@eclipse-foundation.orgFix support for GH project org and ignored reposUsed auto-format in test, so there are a lot of whitespace changes along
with 2 new tests and 1 modified test.Used auto-format in test, so there are a lot of whitespace changes along
with 2 new tests and 1 modified test.https://gitlab.eclipse.org/eclipsefdn/it/api/git-eca-rest-api/-/merge_requests/136Swap error and failure GH commit status messages2023-05-26T19:03:08ZMartin Lowemartin.lowe@eclipse-foundation.orgSwap error and failure GH commit status messagesWhen first committed, the error and failure messages were swapped,
meaning the error message when commits can't be produced were associated
with ECA status failures (which is a legitimate state).When first committed, the error and failure messages were swapped,
meaning the error message when commits can't be produced were associated
with ECA status failures (which is a legitimate state).https://gitlab.eclipse.org/eclipsefdn/it/api/git-eca-rest-api/-/merge_requests/135Set cache time to 15m from 1h for API calls2023-05-17T14:54:35ZMartin Lowemartin.lowe@eclipse-foundation.orgSet cache time to 15m from 1h for API callsThis cache time upgrade will make the system much more responsive to
downstream requests, but still give us enough of a cache buffer to still
be useful.This cache time upgrade will make the system much more responsive to
downstream requests, but still give us enough of a cache buffer to still
be useful.https://gitlab.eclipse.org/eclipsefdn/it/api/git-eca-rest-api/-/merge_requests/134Add sonar support, do some no risk changes2023-05-17T14:54:56ZMartin Lowemartin.lowe@eclipse-foundation.orgAdd sonar support, do some no risk changesChanges include adding equals+hashCode to DTOs, fixing test assertions,
and adding some accessibility to HTML templates.Changes include adding equals+hashCode to DTOs, fixing test assertions,
and adding some accessibility to HTML templates.https://gitlab.eclipse.org/eclipsefdn/it/api/git-eca-rest-api/-/merge_requests/133Fix error when new required field is empty in prevalidation (usermail)2023-05-05T13:31:43ZMartin Lowemartin.lowe@eclipse-foundation.orgFix error when new required field is empty in prevalidation (usermail)There was an error as the usermail was assumed to always be present, but
its a new field. We should only consider it current if that field is
set.There was an error as the usermail was assumed to always be present, but
its a new field. We should only consider it current if that field is
set.https://gitlab.eclipse.org/eclipsefdn/it/api/git-eca-rest-api/-/merge_requests/132Fix GH commit status path and how non-open PRs are evaluated2023-05-04T20:29:08ZMartin Lowemartin.lowe@eclipse-foundation.orgFix GH commit status path and how non-open PRs are evaluatedPreviously, empty and non-open PRs from Github would be evaluated in
such a way to look valid when there is no commit data to evaluate. This
is inaccurate as we should instead throw or indicate that the PR is
closed.Previously, empty and non-open PRs from Github would be evaluated in
such a way to look valid when there is no commit data to evaluate. This
is inaccurate as we should instead throw or indicate that the PR is
closed.https://gitlab.eclipse.org/eclipsefdn/it/api/git-eca-rest-api/-/merge_requests/131Add new status URL for GH, remove fingerprint logic from GH webhook code2023-04-17T12:49:52ZMartin Lowemartin.lowe@eclipse-foundation.orgAdd new status URL for GH, remove fingerprint logic from GH webhook codeTo better target data and remove some outdated tracking methods, the
previous fingerprint mechanism has been removed from the GH webhook
code. Additionally, a new status URL matching the format
git/eca/status/gh/{fullRepoUrl}/{prNumber} ...To better target data and remove some outdated tracking methods, the
previous fingerprint mechanism has been removed from the GH webhook
code. Additionally, a new status URL matching the format
git/eca/status/gh/{fullRepoUrl}/{prNumber} has been added to remove the
need for a fingerprint.https://gitlab.eclipse.org/eclipsefdn/it/api/git-eca-rest-api/-/merge_requests/130Iss #126 - Add stepsecurity bot to allowlist for ECA checks2023-04-05T12:49:29ZMartin Lowemartin.lowe@eclipse-foundation.orgIss #126 - Add stepsecurity bot to allowlist for ECA checksResolves #126Resolves #126https://gitlab.eclipse.org/eclipsefdn/it/api/git-eca-rest-api/-/merge_requests/129Iss #113 - Update obfuscation logic to use new somewhat readable format2023-03-17T13:25:48ZMartin Lowemartin.lowe@eclipse-foundation.orgIss #113 - Update obfuscation logic to use new somewhat readable formatThe new format transforms `sample@somecorp.co` into `sample@some*orp DOT
co`, which is more human readable but is still difficult for machines to
parse and determine.
Resolves #113The new format transforms `sample@somecorp.co` into `sample@some*orp DOT
co`, which is more human readable but is still difficult for machines to
parse and determine.
Resolves #113https://gitlab.eclipse.org/eclipsefdn/it/api/git-eca-rest-api/-/merge_requests/128Iss #123 - Update status UI page to handle revalidation more intuitively2023-03-10T16:33:51ZMartin Lowemartin.lowe@eclipse-foundation.orgIss #123 - Update status UI page to handle revalidation more intuitivelyAdds blocking form processing on the page for revalidation form so that
we can more naturally handle errors.
Resolves #123Adds blocking form processing on the page for revalidation form so that
we can more naturally handle errors.
Resolves #123https://gitlab.eclipse.org/eclipsefdn/it/api/git-eca-rest-api/-/merge_requests/127Fix error in interest group model mapping2023-03-09T17:53:14ZMartin Lowemartin.lowe@eclipse-foundation.orgFix error in interest group model mappinghttps://gitlab.eclipse.org/eclipsefdn/it/api/git-eca-rest-api/-/merge_requests/126Add strict mode flag for GH webhook (re)processing2023-03-09T17:53:39ZMartin Lowemartin.lowe@eclipse-foundation.orgAdd strict mode flag for GH webhook (re)processingCurrently, if a request comes in from the webhook, we should be strict
for all requests to get actual results rather than results with
warnings.Currently, if a request comes in from the webhook, we should be strict
for all requests to get actual results rather than results with
warnings.https://gitlab.eclipse.org/eclipsefdn/it/api/git-eca-rest-api/-/merge_requests/125Iss #121 - Add noreply support to bot email checks2023-08-02T14:58:52ZMartin Lowemartin.lowe@eclipse-foundation.orgIss #121 - Add noreply support to bot email checksResolves #121Resolves #121https://gitlab.eclipse.org/eclipsefdn/it/api/git-eca-rest-api/-/merge_requests/124Iss #116 - Add revalidation support2023-03-02T13:58:31ZMartin Lowemartin.lowe@eclipse-foundation.orgIss #116 - Add revalidation supportAdds new table for storing data for revalidation, and adds mechanisms in status UI for revalidation.
Resolves #116Adds new table for storing data for revalidation, and adds mechanisms in status UI for revalidation.
Resolves #116https://gitlab.eclipse.org/eclipsefdn/it/api/git-eca-rest-api/-/merge_requests/123Iss #114 - Add support for estimated LOC and IP team note in status UI2023-01-26T21:20:57ZMartin Lowemartin.lowe@eclipse-foundation.orgIss #114 - Add support for estimated LOC and IP team note in status UIUpdates the request body to allow a passed estimated LOC changed by a
PR. This allows us when set to more accurately show the IP management
message on the status UI. As the current Gitlab solution is separated
from the origin remote and ...Updates the request body to allow a passed estimated LOC changed by a
PR. This allows us when set to more accurately show the IP management
message on the status UI. As the current Gitlab solution is separated
from the origin remote and PR, this solution won't work in the current
state, so a bypass has been added that will always show the message.
Resolves #114.https://gitlab.eclipse.org/eclipsefdn/it/api/git-eca-rest-api/-/merge_requests/122Iss #112 - Add help message related to common troubleshooting to ui2023-01-27T19:44:20ZMartin Lowemartin.lowe@eclipse-foundation.orgIss #112 - Add help message related to common troubleshooting to uiResolves #112Resolves #112