404 handler incorrectly parses + symbol

Summary

Follow up to #2219 (closed)

Our download space at https://download.eclipse.org/temurin-compliance/temurin/ seems to have differnet permissions fo diufferent areas. e.g. https://download.eclipse.org/temurin-compliance/temurin/8/jdk8u352-b08/ has a visible listing of the directory contents and and others such as https://download.eclipse.org/temurin-compliance/temurin/17/jdk-17.0.5+8/ do not.

I don't think I've done anything explicitly to enable if for the one that's working. Is there an obvious reason why they would be different?

Steps to reproducee

See the above URLs

What is the current bug behavior?

Directory listing is not visible (or is visible, depending on which one you're looking at)

What is the expected correct behavior?

Consistent behaviour across all directories

Relevant logs and/or screenshots

(Add a link to or paste any relevant logs - please use code blocks (```) to format console output, logs, and code, as it's very hard to read otherwise.)

Priority

• Urgent
• High
• Medium
• Low

Severity

• Blocker
• Major
• Normal
• Low

Impact

Not severe as I believe the data is all still in there regardless.

The directory listing is driven from the 404 handler. I am willing to bet that the + sign in the URL is the reason a Not Found is generated.

I'll have a look early next week.

That's a good spot - thanks. The format of the JDK versions strings for 11 and up are different from 8 (which doesn't have a +)

assigned to @droy

changed title from Permissions on download side appear incorrect to Permissions on download site appear inconsistent

added IT-prioritylow IT-severitylow ~26502 ~21670 labels

changed due date to January 17, 2023

changed due date to January 20, 2023

changed due date to January 25, 2023

@epoirier At line 261 of this file, we pass the current dir through urldecode which, in this case, is replacing the + symbol with a space.

https://git.eclipse.org/c/www.eclipse.org/eclipse.org-common.git/tree/classes/downloads/downloadDirectory.class.php#n261

Seeking guidance on how to best handle this.

/cc @webdev

Have you tried using https://www.php.net/manual/en/function.rawurldecode.php instead of urldecode()? The only real difference is how they handle the + sign

In my test environment, that does give me the plus sign. Thanks, patch pending.

https://git.eclipse.org/r/c/www.eclipse.org/eclipse.org-common/+/199804

removed due date

changed title from Permissions on download site appear inconsistent to 404 handler incorrectly parses + symbol

Works! The directory listing is now visible for https://download.eclipse.org/temurin-compliance/temurin/17/jdk-17.0.5+8/

closed

Thanks - I've uploaded the latest ones and they're in place too now susccessfully and they are visible, although the server had lost the key required to verify the host key so the upload was giving Host key verification failed which @fgurr has resolved for me (Second time that has happened - he'll work on a permanent solution).