NPE in RemoteFile.getFolders() when using a picker dialog to create a new folder

Bugzilla Link	422956
Status	NEW
Importance	P3 normal
Reported	Dec 02, 2013 09:35 EDT
Modified	Dec 02, 2013 09:36 EDT
Version	3.4.2
Reporter	Chris McGee

Description

When using a picker dialog (with a special purpose validator) to create a remote folder an NPE is thrown.

Here is a partial stack trace:

!ENTRY org.eclipse.jface 4 2 2013-12-02 09:10:54.875
!MESSAGE Problems occurred when invoking code from plug-in: "org.eclipse.jface".
!STACK 0
java.lang.NullPointerException
at org.eclipse.rse.subsystems.files.core.subsystems.RemoteFile.getFolders(RemoteFile.java:671)
at org.eclipse.rse.subsystems.files.core.subsystems.RemoteFile.getContents(RemoteFile.java:718)
at org.eclipse.rse.subsystems.files.core.subsystems.RemoteFile.getContents(RemoteFile.java:631)
at MyValidator.isValid(SandboxParentValidator.java:40)
at org.eclipse.rse.internal.ui.view.SystemResourceSelectionForm.selectionChanged(SystemResourceSelectionForm.java:550)
at org.eclipse.jface.viewers.Viewer$2.run(Viewer.java:162)
at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:49)
at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:175)
at org.eclipse.jface.viewers.Viewer.fireSelectionChanged(Viewer.java:160)
at org.eclipse.jface.viewers.StructuredViewer.updateSelection(StructuredViewer.java:2162)
at org.eclipse.jface.viewers.StructuredViewer.handleSelect(StructuredViewer.java:1190)
at org.eclipse.jface.viewers.StructuredViewer$4.widgetSelected(StructuredViewer.java:1220)
at org.eclipse.jface.util.OpenStrategy.fireSelectionEvent(OpenStrategy.java:228)
at org.eclipse.jface.util.OpenStrategy.access$4(OpenStrategy.java:222)
at org.eclipse.jface.util.OpenStrategy$1.handleEvent(OpenStrategy.java:389)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1258)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3540)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3161)
at org.eclipse.jface.window.Window.runEventLoop(Window.java:825)
at org.eclipse.jface.window.Window.open(Window.java:801)

The problem is that getContents() returns null at certain times. Also, it is recursive but when it calls getFolders() it does not expect null.