GitLab

Improve handling of socket error/close

Vadim Yanitskiy authored Mar 23, 2021 and Vadim Yanitskiy committed Mar 23, 2021

Signed-off-by: Vadim Yanitskiy <axilirator@gmail.com>

Vadim Yanitskiy authored Mar 23, 2021 and Vadim Yanitskiy committed Mar 23, 2021

Signed-off-by: Vadim Yanitskiy <axilirator@gmail.com>

cosmetic: Update lot lines + remove comment on old Event_Handler

This port is supporting the "new" epoll based event handling,
it should not print confusing log messages implying the old select
Event_Handler methods still being used.
Signed-off-by: Harald Welte <laforge@gnumonks.org>

Signed-off-by: balaskoa <Jeno.Balasko@ericsson.com>

Signed-off-by: balaskoa <Jeno.Balasko@ericsson.com>

Add "getMsgLen" function similar to IPL4asp_PT

When a SOCK_STREAM socket is used for a message-based protocol, we
must make sure to properly de-segment the messages at their boundary.

In order to do so, we introduce a call-back function which the user
can provide in order to assist the UD_PT_PROVIDER in finding the
length of the messages processed.

TODO: Documentation is not updated yet
Signed-off-by: Harald Welte <laforge@gnumonks.org>

In commit 06923f0f

 I introduced
a compiler warning:

g++  -c -DLINUX -DMAKEDEPEND_RUN -I/usr/include -I/usr/include/titan -Wall -fPIC   -o UD_PT.o UD_PT.cc
In file included from UD_PortType.hh:21:0,
                 from UD_PT.cc:19:
UD_PT.hh: In constructor ‘UD__PortType::UD__PT_PROVIDER::UD__PT_PROVIDER(const char*)’:
UD_PT.hh:120:7: warning: ‘UD__PortType::UD__PT_PROVIDER::target_fd’ will be initialized after [-Wreorder]
   int target_fd;
       ^~~~~~~~~
UD_PT.hh:102:7: warning:   ‘int UD__PortType::UD__PT_PROVIDER::sock_type’ [-Wreorder]
   int sock_type;
       ^~~~~~~~~
UD_PT.cc:41:1: warning:   when initialized here [-Wreorder]
 UD__PT_PROVIDER::UD__PT_PROVIDER(const char *par_port_name)
 ^~~~~~~~~~~~~~~

This patch resolves/removes the warning by changing the initialization
order.
Signed-off-by: Harald Welte <laforge@gnumonks.org>

Support SOCK_DGRAM and SOCK_SEQPACKET unix domain sockets

This introduces a new testport parameter "socket_type", which can
be set either to "STREAM" (default), "DGRAM" or "SEQPACKET" in
order to determine the socket type of the underlying unix domain
socket.

Please note that SOCK_SEQPACKET unix domain sockets are present on
Linux but may not be present on other operating systems.
Signed-off-by: Harald Welte <laforge@gnumonks.org>