Unused variables and other warnings clean up
Several warnings: ``` EPTF_CLL_UIHandler_GUIFunctions.cc: In function ‘bool EPTF__CLL__UIHandler__WidgetFunctions::remove_XML(const CHARSTRING&)’: EPTF_CLL_UIHandler_GUIFunctions.cc:1031:25: warning: variable ‘vl_node_parent’ set but not used [-Wunused-but-set-variable] node_parent vl_node_parent = vl_node_map->second; ^~~~~~~~~~~~~~ EPTF_CLL_UIHandler_GUIFunctions.cc:951:23: warning: variable ‘vl_var_data_ptr’ set but not used [-Wunused-but-set-variable] variable_data * vl_var_data_ptr = 0; ^~~~~~~~~~~~~~~ EPTF_CLL_UIHandler_GUIFunctions.cc:952:23: warning: variable ‘vl_var_parent_data_ptr’ set but not used [-Wunused-but-set-variable] variable_data * vl_var_parent_data_ptr = 0; ^~~~~~~~~~~~~~~~~~~~~~ EPTF_CLL_UIHandler_GUIFunctions.cc:953:20: warning: variable ‘vl_orig_node_ptr’ set but not used [-Wunused-but-set-variable] xml_node<> * vl_orig_node_ptr = 0; ^~~~~~~~~~~~~~~~ EPTF_CLL_UIHandler_GUIFunctions.cc: In function ‘void EPTF__CLL__UIHandler__WidgetFunctions::f__EPTF__UIHandler__expand__current__iterator(const CHARSTRING&, const CHARSTRING&, const CHARSTRING&, const EPTF__CLL__DataSource__Definitions::EPTF__DataSource__Params&, const INTEGER&, const CHARSTRING&, const COMPONENT&, const INTEGER&, const EPTF__CLL__Variable__Definitions::EPTF__Var__DirectContent&, const EPTF__IntegerList&)’: EPTF_CLL_UIHandler_GUIFunctions.cc:1901:41: warning: variable ‘vl_data_map’ set but not used [-Wunused-but-set-variable] std::map<long, int>::iterator vl_data_map = v_variableDataMap.find(vl_node_offset_id); ^~~~~~~~~~~ probably the std::map<long, int>::iterator part was not intended. EPTF_CLL_UIHandler_GUIFunctions.cc: In function ‘void EPTF__CLL__UIHandler__WidgetFunctions::out_process_for_metaiterators(rapidxml::xml_document<>*, rapidxml::xml_node<>*, rapidxml::xml_node<>*)’: EPTF_CLL_UIHandler_GUIFunctions.cc:3110:23: warning: variable ‘vl_next_processed_node’ set but not used [-Wunused-but-set-variable] xml_node<> * vl_next_processed_node = 0; ^~~~~~~~~~~~~~~~~~~~~~ EPTF_CLL_UIHandler_GUIFunctions.cc: In function ‘void EPTF__CLL__UIHandler__WidgetFunctions::stop_timer(clock_t*, timeval*, double*)’: EPTF_CLL_UIHandler_GUIFunctions.cc:3742:13: warning: variable ‘timer_end’ set but not used [-Wunused-but-set-variable] clock_t timer_end; ^~~~~~~~~ EPTF_CLL_UIHandler_GUIFunctions.cc: In function ‘void EPTF__CLL__UIHandler__WidgetFunctions::f__EPTF__UIHandler__expand__current__iterator(const CHARSTRING&, const CHARSTRING&, const CHARSTRING&, const EPTF__CLL__DataSource__Definitions::EPTF__DataSource__Params&, const INTEGER&, const CHARSTRING&, const COMPONENT&, const INTEGER&, const EPTF__CLL__Variable__Definitions::EPTF__Var__DirectContent&, const EPTF__IntegerList&)’: EPTF_CLL_UIHandler_GUIFunctions.cc:1545:8: warning: ‘%ld’ directive writing between 1 and 19 bytes into a region of size 16 [-Wformat-overflow=] void f__EPTF__UIHandler__expand__current__iterator( const CHARSTRING& pl_source, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ EPTF_CLL_UIHandler_GUIFunctions.cc:1545:8: note: directive argument in the range [0, 2305843009213693951] EPTF_CLL_UIHandler_GUIFunctions.cc:1747:16: note: ‘sprintf’ output between 2 and 20 bytes into a destination of size 16 sprintf(vl_value_idx,"%ld",i); ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~ The #define SIZE_OF_LONG 16 should be 20 EPTF_CLL_Base_ExternalFunctions.cc: In function ‘INTEGER EPTF__CLL__Base__Functions::f__EPTF__Base__executeShell(const CHARSTRING&, CHARSTRING&, CHARSTRING&, const BOOLEAN&)’: EPTF_CLL_Base_ExternalFunctions.cc:244:13: warning: ISO C++ forbids converting a string constant to ‘char*’ [-Wwrite-strings] argv[0]="false"; ^~~~~~~ In file included from EPTF_CLL_HashMapInt2Int_ExternalFunctions.cc:17:0: EPTF_CLL_HashMap_ExternalFunctions.hh: In instantiation of ‘EPTF__CLL__HashMap__Functions::HashMapTypeCT<T, H, F>::~HashMapTypeCT() [with T = INTEGER; H = EPTF__CLL__HashMapInt2Int__Functions::EPTF_HashMap_hash; F = EPTF__CLL__HashMap__Functions::EPTF_HashMap_EqDef<INTEGER>]’: EPTF_CLL_HashMapInt2Int_ExternalFunctions.cc:127:10: required from here EPTF_CLL_HashMap_ExternalFunctions.hh:220:9: warning: throw will always call terminate() [-Wterminate] throw; ^~~~~ In file included from EPTF_CLL_HashMapOct2Int_ExternalFunctions.cc:17:0: EPTF_CLL_HashMap_ExternalFunctions.hh: In instantiation of ‘EPTF__CLL__HashMap__Functions::HashMapTypeCT<T, H, F>::~HashMapTypeCT() [with T = OCTETSTRING; H = EPTF__CLL__HashMapOct2Int__Functions::EPTF_HashMap_hash; F = EPTF__CLL__HashMap__Functions::EPTF_HashMap_EqDef<OCTETSTRING>]’: EPTF_CLL_HashMapOct2Int_ExternalFunctions.cc:100:10: required from here EPTF_CLL_HashMap_ExternalFunctions.hh:220:9: warning: throw will always call terminate() [-Wterminate] throw; ^~~~~ EPTF_CLL_SMacro_ExternalFunctions.cc: In function ‘CHARSTRING EPTF__CLL__SMacro__Functions::f__EPTF__SMacro__getMacroWithPar(const CHARSTRING&, const INTEGER&, CHARSTRING&, CHARSTRING&)’: EPTF_CLL_SMacro_ExternalFunctions.cc:119:44: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses] while(isalnum(str[pos]) || str[pos]=='_' && pos<len) pos++; // alphanumeric and "_" characters for macro name ~~~~~~~~~~~~~~^~~~~~~~~~ EPTF_CLL_SMacro_ExternalFunctions.cc: In function ‘void EPTF__CLL__SMacro__Functions::f__EPTF__SMacro__getExpression(const CHARSTRING&, CHARSTRING&, CHARSTRING&, CHARSTRING&, CHARSTRING&, CHARSTRING&, CHARSTRING&, CHARSTRING&)’: EPTF_CLL_SMacro_ExternalFunctions.cc:249:8: warning: variable ‘eSignFound’ set but not used [-Wunused-but-set-variable] bool eSignFound=false; ^~~~~~~~~~ EPTF_CLL_TransportIPL2_ExternalFunctions.cc: In function ‘void EPTF__CLL__TransportIPL2__Functions::f__EPTF__TransportIPL2__getHostRoutingTable(EPTF__CLL__TransportIPL2__Definitions::EPTF__TransportIPL2__RouteTable&)’: EPTF_CLL_TransportIPL2_ExternalFunctions.cc:877:22: warning: ISO C++ forbids converting a string constant to ‘char*’ [-Wwrite-strings] "IRTT", "%d", NULL); ^ ```
issue

Copyright © Eclipse Foundation AISBL. All rights reserved.     Privacy Policy | Terms of Use | Copyright Agent