Commit 81ba8ae7 authored by Kristof Szabados's avatar Kristof Szabados
Browse files

could be final.


Signed-off-by: Kristof Szabados's avatarKristof Szabados <Kristof.Szabados@ericsson.com>
parent 35756398
...@@ -227,7 +227,7 @@ class DependencyCollector { ...@@ -227,7 +227,7 @@ class DependencyCollector {
while (!(allDefs.containsAll(prevDefs))) { while (!(allDefs.containsAll(prevDefs))) {
currDefs = new HashSet<Assignment>(); currDefs = new HashSet<Assignment>();
allDefs.addAll(prevDefs); allDefs.addAll(prevDefs);
for (Assignment d: prevDefs) { for (final Assignment d: prevDefs) {
final DependencyFinderVisitor vis = new DependencyFinderVisitor(currDefs, imports, asnFiles); final DependencyFinderVisitor vis = new DependencyFinderVisitor(currDefs, imports, asnFiles);
d.accept(vis); d.accept(vis);
} }
...@@ -366,13 +366,13 @@ class DependencyCollector { ...@@ -366,13 +366,13 @@ class DependencyCollector {
* */ * */
private static void filterImportDefinitions(final Set<IResource> allFiles, final List<ImportModule> importDefs) { private static void filterImportDefinitions(final Set<IResource> allFiles, final List<ImportModule> importDefs) {
final List<Identifier> allFileIds = new ArrayList<Identifier>(allFiles.size()); final List<Identifier> allFileIds = new ArrayList<Identifier>(allFiles.size());
for (IResource r: allFiles) { for (final IResource r: allFiles) {
if (!(r instanceof IFile)) { if (!(r instanceof IFile)) {
continue; continue;
} }
final IFile f = (IFile)r; final IFile f = (IFile)r;
IProject sourceProject = f.getProject(); final IProject sourceProject = f.getProject();
final ProjectSourceParser projectSourceParser = GlobalParser.getProjectSourceParser(sourceProject); final ProjectSourceParser projectSourceParser = GlobalParser.getProjectSourceParser(sourceProject);
final Module m = projectSourceParser.containedModule(f); final Module m = projectSourceParser.containedModule(f);
allFileIds.add(m.getIdentifier()); allFileIds.add(m.getIdentifier());
...@@ -393,13 +393,13 @@ class DependencyCollector { ...@@ -393,13 +393,13 @@ class DependencyCollector {
* */ * */
private static void filterFriendDefinitions(final Set<IResource> allFiles, final List<FriendModule> friendDefs) { private static void filterFriendDefinitions(final Set<IResource> allFiles, final List<FriendModule> friendDefs) {
final List<Identifier> allFileIds = new ArrayList<Identifier>(allFiles.size()); final List<Identifier> allFileIds = new ArrayList<Identifier>(allFiles.size());
for (IResource r: allFiles) { for (final IResource r: allFiles) {
if (!(r instanceof IFile)) { if (!(r instanceof IFile)) {
continue; continue;
} }
final IFile f = (IFile)r; final IFile f = (IFile)r;
IProject sourceProject = f.getProject(); final IProject sourceProject = f.getProject();
final ProjectSourceParser projectSourceParser = GlobalParser.getProjectSourceParser(sourceProject); final ProjectSourceParser projectSourceParser = GlobalParser.getProjectSourceParser(sourceProject);
final Module m = projectSourceParser.containedModule(f); final Module m = projectSourceParser.containedModule(f);
allFileIds.add(m.getIdentifier()); allFileIds.add(m.getIdentifier());
......
...@@ -225,7 +225,7 @@ public class ExtractDefinitionRefactoring { ...@@ -225,7 +225,7 @@ public class ExtractDefinitionRefactoring {
} }
//create all folders from project level towards file level //create all folders from project level towards file level
for (IFolder f: folders) { for (final IFolder f: folders) {
if (!f.exists()) { if (!f.exists()) {
f.create(true, true, new NullProgressMonitor()); f.create(true, true, new NullProgressMonitor());
} }
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment