Commit 007e4a2d authored by Kristof Szabados's avatar Kristof Szabados
Browse files

method argument could be final


Signed-off-by: Kristof Szabados's avatarkristof <Kristof.Szabados@ericsson.com>
parent 7e8fd16c
......@@ -279,7 +279,7 @@ public abstract class BaseExecutor {
}
}
private String resolvePathFromAttribute(ILaunchConfiguration configuration, String projectLocation, String attribute) throws CoreException {
private String resolvePathFromAttribute(final ILaunchConfiguration configuration, final String projectLocation, final String attribute) throws CoreException {
String path = configuration.getAttribute(attribute, (String) null);
if (!isNullOrEmpty(path)) {
URI uri = TITANPathUtilities.resolvePathURI(path, projectLocation);
......@@ -728,12 +728,12 @@ public abstract class BaseExecutor {
}
}
private boolean isDeleteLogFilesSet(IPreferenceStore preferenceStore) {
private boolean isDeleteLogFilesSet(final IPreferenceStore preferenceStore) {
return Boolean.parseBoolean(getOverlayedPreferenceValue(
preferenceStore, project, PreferenceConstants.EXECUTOR_PREFERENCE_PAGE_ID, PreferenceConstants.DELETE_LOG_FILES_NAME));
}
private boolean isLogFolderSet(IPreferenceStore preferenceStore) {
private boolean isLogFolderSet(final IPreferenceStore preferenceStore) {
return Boolean.parseBoolean(getOverlayedPreferenceValue(
preferenceStore,
project,
......@@ -793,7 +793,7 @@ public abstract class BaseExecutor {
mergeLog.run(filesToMerge, false);
}
private boolean isAutomaticMergeEnabled(IPreferenceStore preferenceStore) {
private boolean isAutomaticMergeEnabled(final IPreferenceStore preferenceStore) {
return Boolean.parseBoolean(getOverlayedPreferenceValue(
preferenceStore, project, PreferenceConstants.EXECUTOR_PREFERENCE_PAGE_ID, PreferenceConstants.AUTOMATIC_MERGE_NAME));
}
......
......@@ -50,7 +50,7 @@ public abstract class LaunchShortcut implements ILaunchShortcut {
public abstract boolean initLaunchConfiguration(final ILaunchConfigurationWorkingCopy configuration,
final IProject project, final String configFilePath);
protected ILaunchConfigurationWorkingCopy getWorkingCopy(final IProject project, IFile file, final String mode) {
protected ILaunchConfigurationWorkingCopy getWorkingCopy(final IProject project, final IFile file, final String mode) {
try {
final ILaunchConfigurationType configurationType = DebugPlugin.getDefault().getLaunchManager().getLaunchConfigurationType(getConfigurationId());
......
......@@ -48,7 +48,7 @@ public abstract class LaunchShortcutConfig implements ILaunchShortcut {
public abstract boolean initLaunchConfiguration(final ILaunchConfigurationWorkingCopy configuration,
final IProject project, final String configFilePath);
protected ILaunchConfigurationWorkingCopy getWorkingCopy(final IProject project, IFile file, final String mode) {
protected ILaunchConfigurationWorkingCopy getWorkingCopy(final IProject project, final IFile file, final String mode) {
try {
final ILaunchConfigurationType configurationType = DebugPlugin.getDefault().getLaunchManager().getLaunchConfigurationType(getConfigurationId());
......
......@@ -27,7 +27,7 @@ public final class LaunchShortcut extends org.eclipse.titan.executor.executors.L
}
@Override
public boolean initLaunchConfiguration(ILaunchConfigurationWorkingCopy configuration, IProject project, String configFilePath) {
public boolean initLaunchConfiguration(final ILaunchConfigurationWorkingCopy configuration, final IProject project, final String configFilePath) {
return JNIMainControllerTab.initLaunchConfiguration(configuration, project, configFilePath);
}
......
......@@ -26,7 +26,7 @@ public final class LaunchShortcutConfig extends org.eclipse.titan.executor.execu
}
@Override
public boolean initLaunchConfiguration(ILaunchConfigurationWorkingCopy configuration, IProject project, String configFilePath) {
public boolean initLaunchConfiguration(final ILaunchConfigurationWorkingCopy configuration, final IProject project, final String configFilePath) {
return JNIMainControllerTab.initLaunchConfiguration(configuration, project, configFilePath);
}
}
......@@ -350,7 +350,7 @@ public final class CliExecutor extends BaseExecutor {
}
}
private boolean addConfigFilePath(String mctrCliPath, List<String> command) {
private boolean addConfigFilePath(final String mctrCliPath, final List<String> command) {
if (isLogFolderSet()) {
if (!StringUtils.isNullOrEmpty(configFilePath)) {
configHandler = readConfigFile();
......@@ -406,7 +406,7 @@ public final class CliExecutor extends BaseExecutor {
return Boolean.parseBoolean(preferenceValue);
}
private void printCommandToTitanConsole(List<String> command) {
private void printCommandToTitanConsole(final List<String> command) {
MessageConsoleStream stream = TITANConsole.getConsole().newMessageStream();
for (String c : command) {
stream.print(c + ' ');
......@@ -414,7 +414,7 @@ public final class CliExecutor extends BaseExecutor {
stream.println();
}
private String getMctrPath(Map<String, String> env) {
private String getMctrPath(final Map<String, String> env) {
String mctrCliPath;
if (env.containsKey("TTCN3_DIR")) {
mctrCliPath = "$TTCN3_DIR/bin/mctr_cli";
......
......@@ -26,7 +26,7 @@ public final class LaunchShortcut extends org.eclipse.titan.executor.executors.L
}
@Override
public boolean initLaunchConfiguration(ILaunchConfigurationWorkingCopy configuration, IProject project, String configFilePath) {
public boolean initLaunchConfiguration(final ILaunchConfigurationWorkingCopy configuration, final IProject project, final String configFilePath) {
return MctrCliMainControllerTab.initLaunchConfiguration(configuration, project, configFilePath);
}
}
......@@ -26,7 +26,7 @@ public final class LaunchShortcutConfig extends org.eclipse.titan.executor.execu
}
@Override
public boolean initLaunchConfiguration(ILaunchConfigurationWorkingCopy configuration, IProject project, String configFilePath) {
public boolean initLaunchConfiguration(final ILaunchConfigurationWorkingCopy configuration, final IProject project, final String configFilePath) {
return MctrCliMainControllerTab.initLaunchConfiguration(configuration, project, configFilePath);
}
}
......@@ -27,7 +27,7 @@ public final class LaunchShortcut extends org.eclipse.titan.executor.executors.L
}
@Override
public boolean initLaunchConfiguration(ILaunchConfigurationWorkingCopy configuration, IProject project, String configFilePath) {
public boolean initLaunchConfiguration(final ILaunchConfigurationWorkingCopy configuration, final IProject project, final String configFilePath) {
return SingleMainControllerTab.initLaunchConfiguration(configuration, project, configFilePath);
}
}
......@@ -26,7 +26,7 @@ public final class LaunchShortcutConfig extends org.eclipse.titan.executor.execu
}
@Override
public boolean initLaunchConfiguration(ILaunchConfigurationWorkingCopy configuration, IProject project, String configFilePath) {
public boolean initLaunchConfiguration(final ILaunchConfigurationWorkingCopy configuration, final IProject project, final String configFilePath) {
return SingleMainControllerTab.initLaunchConfiguration(configuration, project, configFilePath);
}
}
......@@ -711,7 +711,7 @@ public abstract class BaseMainControllerTab extends AbstractLaunchConfigurationT
}
@Override
public boolean isValid(ILaunchConfiguration launchConfig) {
public boolean isValid(final ILaunchConfiguration launchConfig) {
if (!EMPTY.equals(projectNameText.getText()) && !projectIsValid) {
setErrorMessage("The name of the project is not valid.");
......
......@@ -231,7 +231,7 @@ public final class TestExecutionView extends ViewPart implements ISelectionListe
setTitleToolTip(statistics);
}
private String createStatistics(ITreeLeaf element, List<ExecutedTestcase> executedTestCases) {
private String createStatistics(final ITreeLeaf element, final List<ExecutedTestcase> executedTestCases) {
int inconc = 0;
int fail = 0;
int error = 0;
......@@ -306,7 +306,7 @@ public final class TestExecutionView extends ViewPart implements ISelectionListe
return instance;
}
private static synchronized void setInstance(TestExecutionView instance) {
private static synchronized void setInstance(final TestExecutionView instance) {
TestExecutionView.instance = instance;
}
}
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment