opSimulation v1.2.0 - "Version is falsely set"

The CI build of v1.2.0 was not successful and lead to this error:

https://ci.eclipse.org/openpass/job/openPASS_simulator_build/view/tags/job/v1.2.0/

I assume this needs to be fixed before we can link to a new release here: eclipsefdn/it/websites/openpass.eclipse.org#118 (closed)

assigned to @barbarakohn, @rbiegel, and @adascri

First analysis: W:\dist\opSimulation\opSimulation.exe 1.2.0 tells me that opSimulation reports 1.2.0. The script checks for the actual TAG, which is v1.2.0.

I'd got for allowing both, so the fix in 89_check_version.sh would be:

# Check if the output is exactly the tag name
if [[ "$version_output" == *"${TAG_NAME}" || "$version_output" == *"v${TAG_NAME}" ]]; then
    echo "Version is correctly set: $version_output"
else
    echo "Version is falsely set: $version_output"
    exit 1
fi

How shall we proceed - patching main and moving the TAG?

Sounds like a plan!

The main build was aborted due to time out, so re-triggering this build makes sense, too

assigned to @rparisha2

mentioned in commit 9192dfcc

mentioned in merge request !268 (merged)

changed milestone to %Release v1.2.0

mentioned in merge request !269 (merged)

mentioned in commit f8621dc5

closed with commit 9192dfcc

closed with merge request !269 (merged)

@rparisha2 are you deploying a release 1.2.0, too, to which we can link with the Download button on openpass.eclipse.org?