From 7283bb663a314c97fd286e4609daead0ebccca40 Mon Sep 17 00:00:00 2001
From: Rene Paris <rene.paris@in-tech.com>
Date: Wed, 4 Jan 2023 15:28:02 +0100
Subject: [PATCH] Update .clang-tidy and apply related changes

---
 .clang-tidy                                          |  7 +------
 include/MantleAPI/Common/bounding_box.h              |  6 +++---
 include/MantleAPI/Common/i_geometry_helper.h         |  6 +++---
 include/MantleAPI/Common/i_identifiable.h            |  6 +++---
 include/MantleAPI/Common/position.h                  |  6 +++---
 .../EnvironmentalConditions/road_condition.h         |  6 +++---
 include/MantleAPI/Execution/i_environment.h          |  8 ++++----
 include/MantleAPI/Execution/i_scenario_engine.h      |  6 +++---
 include/MantleAPI/Execution/scenario_info.h          |  6 +++---
 include/MantleAPI/Map/i_coord_converter.h            |  6 +++---
 .../MantleAPI/Map/i_lane_location_query_service.h    |  6 +++---
 include/MantleAPI/Map/i_route.h                      |  6 +++---
 include/MantleAPI/Map/map_details.h                  |  6 +++---
 include/MantleAPI/Traffic/control_strategy.h         |  6 +++---
 include/MantleAPI/Traffic/default_routing_behavior.h |  2 +-
 include/MantleAPI/Traffic/entity_properties.h        |  6 +++---
 include/MantleAPI/Traffic/i_controller.h             |  6 +++++-
 include/MantleAPI/Traffic/i_controller_config.h      |  6 +++---
 include/MantleAPI/Traffic/i_controller_repository.h  |  6 +++++-
 include/MantleAPI/Traffic/i_entity.h                 | 12 ++++++------
 include/MantleAPI/Traffic/i_entity_repository.h      |  6 +++---
 include/MantleAPI/Traffic/traffic_light_properties.h |  6 +++---
 22 files changed, 70 insertions(+), 67 deletions(-)

diff --git a/.clang-tidy b/.clang-tidy
index 993819fb..c6046c51 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -3,13 +3,10 @@ Checks: >
   -*,
   boost-*,
   bugprone-*,
-  -bugprone-easily-swappable-parameters,
   cppcoreguidelines-*,
   -cppcoreguidelines-explicit-virtual-functions,
   -cppcoreguidelines-non-private-member-variables-in-classes,
-  -cppcoreguidelines-pro-type-static-cast-downcast,
   -cppcoreguidelines-special-member-functions,
-  -cppcoreguidelines-virtual-class-destructor,
   google-*,
   -google-build-using-namespace,
   -google-default-arguments,
@@ -20,10 +17,8 @@ Checks: >
   misc-*,
   -misc-non-private-member-variables-in-classes,
   modernize-*,
-  -modernize-return-braced-init-list,
-  -modernize-use-equals-default,
   -modernize-use-nodiscard,
-  -modernize-use-override,
+  -modernize-use-equals-default,
   -modernize-use-trailing-return-type,
   -modernize-use-using,
   performance-*,
diff --git a/include/MantleAPI/Common/bounding_box.h b/include/MantleAPI/Common/bounding_box.h
index c7bc0505..1b7d6943 100644
--- a/include/MantleAPI/Common/bounding_box.h
+++ b/include/MantleAPI/Common/bounding_box.h
@@ -12,8 +12,8 @@
 /** @file  bounding_box.h */
 //-----------------------------------------------------------------------------
 
-#ifndef MANTLEAPI_COMMON_BOUNDINGBOX_H
-#define MANTLEAPI_COMMON_BOUNDINGBOX_H
+#ifndef MANTLEAPI_COMMON_BOUNDING_BOX_H
+#define MANTLEAPI_COMMON_BOUNDING_BOX_H
 
 #include <MantleAPI/Common/dimension.h>
 #include <MantleAPI/Common/vector.h>
@@ -38,4 +38,4 @@ inline bool operator==(const BoundingBox& lhs, const BoundingBox& rhs) noexcept
 
 }  // namespace mantle_api
 
-#endif  // MANTLEAPI_COMMON_BOUNDINGBOX_H
+#endif  // MANTLEAPI_COMMON_BOUNDING_BOX_H
diff --git a/include/MantleAPI/Common/i_geometry_helper.h b/include/MantleAPI/Common/i_geometry_helper.h
index 32c35dd0..214c6859 100644
--- a/include/MantleAPI/Common/i_geometry_helper.h
+++ b/include/MantleAPI/Common/i_geometry_helper.h
@@ -12,8 +12,8 @@
 /** @file  i_geometry_helper.h */
 //-----------------------------------------------------------------------------
 
-#ifndef MANTLEAPI_COMMON_IGEOMETRYHELPER_H
-#define MANTLEAPI_COMMON_IGEOMETRYHELPER_H
+#ifndef MANTLEAPI_COMMON_I_GEOMETRY_HELPER_H
+#define MANTLEAPI_COMMON_I_GEOMETRY_HELPER_H
 
 #include <MantleAPI/Common/pose.h>
 
@@ -62,4 +62,4 @@ public:
 
 }  // namespace mantle_api
 
-#endif  // MANTLEAPI_COMMON_IGEOMETRYHELPER_H
+#endif  // MANTLEAPI_COMMON_I_GEOMETRY_HELPER_H
diff --git a/include/MantleAPI/Common/i_identifiable.h b/include/MantleAPI/Common/i_identifiable.h
index cb256f74..a46500c7 100644
--- a/include/MantleAPI/Common/i_identifiable.h
+++ b/include/MantleAPI/Common/i_identifiable.h
@@ -12,8 +12,8 @@
 /** @file  i_identifiable.h */
 //-----------------------------------------------------------------------------
 
-#ifndef MANTLEAPI_COMMON_IIDENTIFIABLE_H
-#define MANTLEAPI_COMMON_IIDENTIFIABLE_H
+#ifndef MANTLEAPI_COMMON_I_IDENTIFIABLE_H
+#define MANTLEAPI_COMMON_I_IDENTIFIABLE_H
 
 #include <cstdint>
 #include <string>
@@ -41,4 +41,4 @@ public:
 
 }  // namespace mantle_api
 
-#endif  // MANTLEAPI_COMMON_IIDENTIFIABLE_H
+#endif  // MANTLEAPI_COMMON_I_IDENTIFIABLE_H
diff --git a/include/MantleAPI/Common/position.h b/include/MantleAPI/Common/position.h
index 430b5dbc..c1acb83e 100644
--- a/include/MantleAPI/Common/position.h
+++ b/include/MantleAPI/Common/position.h
@@ -12,8 +12,8 @@
 /** @file  position.h */
 //-----------------------------------------------------------------------------
 
-#ifndef MANTLEAPI_COMMON_IPOSITION_H
-#define MANTLEAPI_COMMON_IPOSITION_H
+#ifndef MANTLEAPI_COMMON_POSITION_H
+#define MANTLEAPI_COMMON_POSITION_H
 
 #include <MantleAPI/Common/floating_point_helper.h>
 #include <MantleAPI/Common/vector.h>
@@ -103,4 +103,4 @@ inline bool operator!=(const LatLonPosition& lhs, const LatLonPosition& rhs) noe
 }
 
 }  // namespace mantle_api
-#endif  // MANTLEAPI_COMMON_IPOSITION_H
+#endif  // MANTLEAPI_COMMON_POSITION_H
diff --git a/include/MantleAPI/EnvironmentalConditions/road_condition.h b/include/MantleAPI/EnvironmentalConditions/road_condition.h
index a9e3c8d3..dbea4b06 100644
--- a/include/MantleAPI/EnvironmentalConditions/road_condition.h
+++ b/include/MantleAPI/EnvironmentalConditions/road_condition.h
@@ -12,8 +12,8 @@
 /** @file  road_condition.h */
 //-----------------------------------------------------------------------------
 
-#ifndef MANTLEAPI_ENVIRONMENTALCONDITIONS_ROADCONDITION_H
-#define MANTLEAPI_ENVIRONMENTALCONDITIONS_ROADCONDITION_H
+#ifndef MANTLEAPI_ENVIRONMENTALCONDITIONS_ROAD_CONDITION_H
+#define MANTLEAPI_ENVIRONMENTALCONDITIONS_ROAD_CONDITION_H
 
 #include <MantleAPI/Common/position.h>
 #include <units.h>
@@ -32,4 +32,4 @@ struct FrictionPatch
   units::concentration::percent_t friction{100.0};
 };
 }  // namespace mantle_api
-#endif  // MANTLEAPI_ENVIRONMENTALCONDITIONS_ROADCONDITION_H
+#endif  // MANTLEAPI_ENVIRONMENTALCONDITIONS_ROAD_CONDITION_H
diff --git a/include/MantleAPI/Execution/i_environment.h b/include/MantleAPI/Execution/i_environment.h
index f3e33a01..2b244534 100644
--- a/include/MantleAPI/Execution/i_environment.h
+++ b/include/MantleAPI/Execution/i_environment.h
@@ -12,8 +12,8 @@
 /** @file  i_environment.h */
 //-----------------------------------------------------------------------------
 
-#ifndef MANTLEAPI_EXECUTION_IENVIRONMENT_H
-#define MANTLEAPI_EXECUTION_IENVIRONMENT_H
+#ifndef MANTLEAPI_EXECUTION_I_ENVIRONMENT_H
+#define MANTLEAPI_EXECUTION_I_ENVIRONMENT_H
 
 #include <MantleAPI/Common/i_geometry_helper.h>
 #include <MantleAPI/Common/route_definition.h>
@@ -48,7 +48,7 @@ public:
   ///
   /// @param entity The entity to be manipulated by the specified controller.
   /// @param controller_id Identifies the controller to manipulate the entity.
-  virtual void AddEntityToController(IEntity& entity, UniqueId controller_id) = 0;
+  virtual void AddEntityToController(IEntity* entity, UniqueId controller_id) = 0;
 
   virtual void RemoveControllerFromEntity(UniqueId entity_id) = 0;
 
@@ -119,4 +119,4 @@ public:
 };
 }  // namespace mantle_api
 
-#endif  // MANTLEAPI_EXECUTION_IENVIRONMENT_H
+#endif  // MANTLEAPI_EXECUTION_I_ENVIRONMENT_H
diff --git a/include/MantleAPI/Execution/i_scenario_engine.h b/include/MantleAPI/Execution/i_scenario_engine.h
index 0c001560..f4cbff81 100644
--- a/include/MantleAPI/Execution/i_scenario_engine.h
+++ b/include/MantleAPI/Execution/i_scenario_engine.h
@@ -12,8 +12,8 @@
 /** @file  i_scenario_engine.h */
 //-----------------------------------------------------------------------------
 
-#ifndef MANTLEAPI_EXECUTION_ISCENARIOENGINE_H
-#define MANTLEAPI_EXECUTION_ISCENARIOENGINE_H
+#ifndef MANTLEAPI_EXECUTION_I_SCENARIO_ENGINE_H
+#define MANTLEAPI_EXECUTION_I_SCENARIO_ENGINE_H
 
 #include <MantleAPI/Execution/scenario_info.h>
 
@@ -51,4 +51,4 @@ public:
 };
 }  // namespace mantle_api
 
-#endif  // MANTLEAPI_EXECUTION_ISCENARIOENGINE_H
+#endif  // MANTLEAPI_EXECUTION_I_SCENARIO_ENGINE_H
diff --git a/include/MantleAPI/Execution/scenario_info.h b/include/MantleAPI/Execution/scenario_info.h
index 43670dbf..6f5f374f 100644
--- a/include/MantleAPI/Execution/scenario_info.h
+++ b/include/MantleAPI/Execution/scenario_info.h
@@ -12,8 +12,8 @@
 /** @file  scenario_info.h */
 //-----------------------------------------------------------------------------
 
-#ifndef MANTLEAPI_EXECUTION_SCENARIOINFO_H
-#define MANTLEAPI_EXECUTION_SCENARIOINFO_H
+#ifndef MANTLEAPI_EXECUTION_SCENARIO_INFO_H
+#define MANTLEAPI_EXECUTION_SCENARIO_INFO_H
 
 #include <MantleAPI/Common/time_utils.h>
 
@@ -31,4 +31,4 @@ struct ScenarioInfo
 
 }  // namespace mantle_api
 
-#endif  // MANTLEAPI_EXECUTION_SCENARIOINFO_H
+#endif  // MANTLEAPI_EXECUTION_SCENARIO_INFO_H
diff --git a/include/MantleAPI/Map/i_coord_converter.h b/include/MantleAPI/Map/i_coord_converter.h
index bdb6fe5b..1b03af12 100644
--- a/include/MantleAPI/Map/i_coord_converter.h
+++ b/include/MantleAPI/Map/i_coord_converter.h
@@ -12,8 +12,8 @@
 /** @file  i_coord_converter.h */
 //-----------------------------------------------------------------------------
 
-#ifndef MANTLEAPI_MAP_ICOORDCONVERTER_H
-#define MANTLEAPI_MAP_ICOORDCONVERTER_H
+#ifndef MANTLEAPI_MAP_I_COORD_CONVERTER_H
+#define MANTLEAPI_MAP_I_COORD_CONVERTER_H
 
 #include <MantleAPI/Common/position.h>
 #include <MantleAPI/Common/vector.h>
@@ -33,4 +33,4 @@ public:
 
 }  // namespace mantle_api
 
-#endif  // MANTLEAPI_MAP_ICOORDCONVERTER_H
+#endif  // MANTLEAPI_MAP_I_COORD_CONVERTER_H
diff --git a/include/MantleAPI/Map/i_lane_location_query_service.h b/include/MantleAPI/Map/i_lane_location_query_service.h
index 505f83f7..61eaef35 100644
--- a/include/MantleAPI/Map/i_lane_location_query_service.h
+++ b/include/MantleAPI/Map/i_lane_location_query_service.h
@@ -12,8 +12,8 @@
 /** @file  i_lane_location_query_service.h */
 //-----------------------------------------------------------------------------
 
-#ifndef MANTLEAPI_MAP_ILANELOCATIONQUERYSERVICE_H
-#define MANTLEAPI_MAP_ILANELOCATIONQUERYSERVICE_H
+#ifndef MANTLEAPI_MAP_I_LANE_LOCATION_QUERY_SERVICE_H
+#define MANTLEAPI_MAP_I_LANE_LOCATION_QUERY_SERVICE_H
 
 #include <MantleAPI/Common/i_identifiable.h>
 #include <MantleAPI/Common/orientation.h>
@@ -145,4 +145,4 @@ public:
 
 }  // namespace mantle_api
 
-#endif  // MANTLEAPI_MAP_ILANELOCATIONQUERYSERVICE_H
+#endif  // MANTLEAPI_MAP_I_LANE_LOCATION_QUERY_SERVICE_H
diff --git a/include/MantleAPI/Map/i_route.h b/include/MantleAPI/Map/i_route.h
index 1b4ebbda..eee882f8 100644
--- a/include/MantleAPI/Map/i_route.h
+++ b/include/MantleAPI/Map/i_route.h
@@ -12,8 +12,8 @@
 /** @file  i_route.h */
 //-----------------------------------------------------------------------------
 
-#ifndef MANTLEAPI_MAP_IROUTE_H
-#define MANTLEAPI_MAP_IROUTE_H
+#ifndef MANTLEAPI_MAP_I_ROUTE_H
+#define MANTLEAPI_MAP_I_ROUTE_H
 
 #include <MantleAPI/Common/i_identifiable.h>
 #include <MantleAPI/Common/vector.h>
@@ -40,4 +40,4 @@ public:
 
 }  // namespace mantle_api
 
-#endif  // MANTLEAPI_MAP_IROUTE_H
+#endif  // MANTLEAPI_MAP_I_ROUTE_H
diff --git a/include/MantleAPI/Map/map_details.h b/include/MantleAPI/Map/map_details.h
index 3f62e1b0..64b118bd 100644
--- a/include/MantleAPI/Map/map_details.h
+++ b/include/MantleAPI/Map/map_details.h
@@ -12,8 +12,8 @@
 /** @file  map_details.h */
 //-----------------------------------------------------------------------------
 
-#ifndef MANTLEAPI_MAP_MAPDETAILS_H
-#define MANTLEAPI_MAP_MAPDETAILS_H
+#ifndef MANTLEAPI_MAP_MAP_DETAILS_H
+#define MANTLEAPI_MAP_MAP_DETAILS_H
 
 #include <MantleAPI/Common/position.h>
 
@@ -29,4 +29,4 @@ struct MapDetails
 };
 
 }  // namespace mantle_api
-#endif  // MANTLEAPI_MAP_MAPDETAILS_H
+#endif  // MANTLEAPI_MAP_MAP_DETAILS_H
diff --git a/include/MantleAPI/Traffic/control_strategy.h b/include/MantleAPI/Traffic/control_strategy.h
index 85f87a59..89e3e25d 100644
--- a/include/MantleAPI/Traffic/control_strategy.h
+++ b/include/MantleAPI/Traffic/control_strategy.h
@@ -12,8 +12,8 @@
 /** @file  control_strategy.h */
 //-----------------------------------------------------------------------------
 
-#ifndef MANTLEAPI_TRAFFIC_CONTROLSTRATEGY_H
-#define MANTLEAPI_TRAFFIC_CONTROLSTRATEGY_H
+#ifndef MANTLEAPI_TRAFFIC_CONTROL_STRATEGY_H
+#define MANTLEAPI_TRAFFIC_CONTROL_STRATEGY_H
 
 #include <MantleAPI/Common/i_identifiable.h>
 #include <MantleAPI/Common/spline.h>
@@ -228,4 +228,4 @@ struct PerformLaneChangeControlStrategy : public ControlStrategy
 
 }  // namespace mantle_api
 
-#endif  // MANTLEAPI_TRAFFIC_CONTROLSTRATEGY_H
+#endif  // MANTLEAPI_TRAFFIC_CONTROL_STRATEGY_H
diff --git a/include/MantleAPI/Traffic/default_routing_behavior.h b/include/MantleAPI/Traffic/default_routing_behavior.h
index cb5604c1..4c70ceaf 100644
--- a/include/MantleAPI/Traffic/default_routing_behavior.h
+++ b/include/MantleAPI/Traffic/default_routing_behavior.h
@@ -22,4 +22,4 @@ enum class DefaultRoutingBehavior
 
 }
 
-#endif //MANTLEAPI_TRAFFIC_DEFAULT_ROUTING_BEHAVIOR_H
\ No newline at end of file
+#endif  // MANTLEAPI_TRAFFIC_DEFAULT_ROUTING_BEHAVIOR_H
\ No newline at end of file
diff --git a/include/MantleAPI/Traffic/entity_properties.h b/include/MantleAPI/Traffic/entity_properties.h
index 65c3b5e4..e40094d6 100644
--- a/include/MantleAPI/Traffic/entity_properties.h
+++ b/include/MantleAPI/Traffic/entity_properties.h
@@ -12,8 +12,8 @@
 /** @file  entity_properties.h */
 //-----------------------------------------------------------------------------
 
-#ifndef MANTLEAPI_TRAFFIC_ENTITYPROPERTIES_H
-#define MANTLEAPI_TRAFFIC_ENTITYPROPERTIES_H
+#ifndef MANTLEAPI_TRAFFIC_ENTITY_PROPERTIES_H
+#define MANTLEAPI_TRAFFIC_ENTITY_PROPERTIES_H
 
 #include <MantleAPI/Common/bounding_box.h>
 #include <MantleAPI/Common/floating_point_helper.h>
@@ -185,4 +185,4 @@ struct StaticObjectProperties : public EntityProperties
 
 }  // namespace mantle_api
 
-#endif  // MANTLEAPI_TRAFFIC_ENTITYPROPERTIES_H
+#endif  // MANTLEAPI_TRAFFIC_ENTITY_PROPERTIES_H
diff --git a/include/MantleAPI/Traffic/i_controller.h b/include/MantleAPI/Traffic/i_controller.h
index fd4a5eb0..33b6066c 100644
--- a/include/MantleAPI/Traffic/i_controller.h
+++ b/include/MantleAPI/Traffic/i_controller.h
@@ -1,3 +1,6 @@
+#ifndef MANTLEAPI_TRAFFIC_I_CONTROLLER_H
+#define MANTLEAPI_TRAFFIC_I_CONTROLLER_H
+
 /********************************************************************************
  * Copyright (c) 2021 in-tech GmbH
  *
@@ -23,4 +26,5 @@ class IController : public IIdentifiable
 {
 };
 
-}  // namespace mantle_api
\ No newline at end of file
+}  // namespace mantle_api
+#endif
diff --git a/include/MantleAPI/Traffic/i_controller_config.h b/include/MantleAPI/Traffic/i_controller_config.h
index 94619725..ce353309 100644
--- a/include/MantleAPI/Traffic/i_controller_config.h
+++ b/include/MantleAPI/Traffic/i_controller_config.h
@@ -12,8 +12,8 @@
 /** @file  i_controller_config.h */
 //-----------------------------------------------------------------------------
 
-#ifndef MANTLEAPI_TRAFFIC_ICONTROLLERCONFIG_H
-#define MANTLEAPI_TRAFFIC_ICONTROLLERCONFIG_H
+#ifndef MANTLEAPI_TRAFFIC_I_CONTROLLER_CONFIG_H
+#define MANTLEAPI_TRAFFIC_I_CONTROLLER_CONFIG_H
 
 #include <MantleAPI/Common/route_definition.h>
 #include <MantleAPI/Common/spline.h>
@@ -86,4 +86,4 @@ struct ExternalControllerConfig : public IControllerConfig
 
 }  // namespace mantle_api
 
-#endif  // MANTLEAPI_TRAFFIC_ICONTROLLERCONFIG_H
+#endif  // MANTLEAPI_TRAFFIC_I_CONTROLLER_CONFIG_H
diff --git a/include/MantleAPI/Traffic/i_controller_repository.h b/include/MantleAPI/Traffic/i_controller_repository.h
index 1ccec9e2..d245c9a2 100644
--- a/include/MantleAPI/Traffic/i_controller_repository.h
+++ b/include/MantleAPI/Traffic/i_controller_repository.h
@@ -1,3 +1,6 @@
+#ifndef MANTLEAPI_TRAFFIC_I_CONTROLLER_REPOSITORY_H
+#define MANTLEAPI_TRAFFIC_I_CONTROLLER_REPOSITORY_H
+
 /********************************************************************************
  * Copyright (c) 2021 in-tech GmbH
  *
@@ -33,4 +36,5 @@ public:
 
 };
 
-}  // namespace mantle_api
\ No newline at end of file
+}  // namespace mantle_api
+#endif
diff --git a/include/MantleAPI/Traffic/i_entity.h b/include/MantleAPI/Traffic/i_entity.h
index c13881e2..3918b9d2 100644
--- a/include/MantleAPI/Traffic/i_entity.h
+++ b/include/MantleAPI/Traffic/i_entity.h
@@ -12,8 +12,8 @@
 /** @file  i_entity.h */
 //-----------------------------------------------------------------------------
 
-#ifndef MANTLEAPI_TRAFFIC_IENTITY_H
-#define MANTLEAPI_TRAFFIC_IENTITY_H
+#ifndef MANTLEAPI_TRAFFIC_I_ENTITY_H
+#define MANTLEAPI_TRAFFIC_I_ENTITY_H
 
 #include <MantleAPI/Common/bounding_box.h>
 #include <MantleAPI/Common/i_identifiable.h>
@@ -86,7 +86,7 @@ public:
 class IVehicle : public virtual IEntity
 {
 public:
-  virtual VehicleProperties* GetProperties() const = 0;
+  VehicleProperties* GetProperties() const override = 0;
 
   virtual void SetIndicatorState(IndicatorState state) = 0;
   virtual IndicatorState GetIndicatorState() const = 0;
@@ -98,15 +98,15 @@ public:
 class IPedestrian : public virtual IEntity
 {
 public:
-  virtual PedestrianProperties* GetProperties() const = 0;
+  PedestrianProperties* GetProperties() const override = 0;
 };
 
 class IStaticObject : public virtual IEntity
 {
 public:
-  virtual StaticObjectProperties* GetProperties() const = 0;
+  StaticObjectProperties* GetProperties() const override = 0;
 };
 
 }  // namespace mantle_api
 
-#endif  // MANTLEAPI_TRAFFIC_IENTITY_H
+#endif  // MANTLEAPI_TRAFFIC_I_ENTITY_H
diff --git a/include/MantleAPI/Traffic/i_entity_repository.h b/include/MantleAPI/Traffic/i_entity_repository.h
index 7a83b561..080d3827 100644
--- a/include/MantleAPI/Traffic/i_entity_repository.h
+++ b/include/MantleAPI/Traffic/i_entity_repository.h
@@ -12,8 +12,8 @@
 /** @file  i_entity_repository.h */
 //-----------------------------------------------------------------------------
 
-#ifndef MANTLEAPI_TRAFFIC_IENTITYREPOSITORY_H
-#define MANTLEAPI_TRAFFIC_IENTITYREPOSITORY_H
+#ifndef MANTLEAPI_TRAFFIC_I_ENTITY_REPOSITORY_H
+#define MANTLEAPI_TRAFFIC_I_ENTITY_REPOSITORY_H
 
 #include <MantleAPI/Traffic/entity_properties.h>
 #include <MantleAPI/Traffic/i_entity.h>
@@ -55,4 +55,4 @@ public:
 
 }  // namespace mantle_api
 
-#endif  // MANTLEAPI_TRAFFIC_IENTITYREPOSITORY_H
+#endif  // MANTLEAPI_TRAFFIC_I_ENTITY_REPOSITORY_H
diff --git a/include/MantleAPI/Traffic/traffic_light_properties.h b/include/MantleAPI/Traffic/traffic_light_properties.h
index 593a7f3f..a6c13f7a 100644
--- a/include/MantleAPI/Traffic/traffic_light_properties.h
+++ b/include/MantleAPI/Traffic/traffic_light_properties.h
@@ -12,8 +12,8 @@
 /** @file  traffic_light_properties.h */
 //-----------------------------------------------------------------------------
 
-#ifndef MANTLEAPI_TRAFFIC_TRAFFICLIGHTPROPERTIES_H
-#define MANTLEAPI_TRAFFIC_TRAFFICLIGHTPROPERTIES_H
+#ifndef MANTLEAPI_TRAFFIC_TRAFFIC_LIGHT_PROPERTIES_H
+#define MANTLEAPI_TRAFFIC_TRAFFIC_LIGHT_PROPERTIES_H
 
 #include <MantleAPI/Common/time_utils.h>
 #include <vector>
@@ -56,4 +56,4 @@ struct TrafficLightPhase
 
 }  // namespace mantle_api
 
-#endif  // MANTLEAPI_TRAFFIC_TRAFFICLIGHTPROPERTIES_H
+#endif  // MANTLEAPI_TRAFFIC_TRAFFIC_LIGHT_PROPERTIES_H
-- 
GitLab