SONARWORK

gfsBackendService/src/main/java/org/eclipse/openk/gridfailureinformation/bpmn/impl/GfiGrid.java

@@ -16,7 +16,6 @@
 package org.eclipse.openk.gridfailureinformation.bpmn.impl;
 
 import lombok.extern.log4j.Log4j2;
-import org.eclipse.openk.gridfailureinformation.bpmn.base.ProcessException;
 import org.eclipse.openk.gridfailureinformation.bpmn.base.ProcessGrid;
 import org.springframework.stereotype.Component;
 
@@ -24,18 +23,7 @@ import org.springframework.stereotype.Component;
 @Component
 public class GfiGrid extends ProcessGrid {
     public GfiGrid() {
-
-        try {
-            init();
-        }
-        catch( ProcessException e ) {
-            log.fatal("Invalid process grid configuration", e );
-            throw new RuntimeException("Invalid process grid configuration"); // NOSONAR _fd
-        }
-    }
-    private void init() throws ProcessException {
         // TODO: Create the Grid here
-
     }
 
 }

gfsBackendService/src/test/java/org/eclipse/openk/gridfailureinformation/bpmn/base/UserInteractionTaskImpl.java

@@ -20,6 +20,7 @@ import org.eclipse.openk.gridfailureinformation.bpmn.base.tasks.UserInteractionT
 public class UserInteractionTaskImpl extends UserInteractionTask<TestProcessSubject> {
     public boolean leaveStepCalled = false;
     public boolean enterStepCalled = false;
+    public boolean stayInTask = false;
 
     public UserInteractionTaskImpl(String description ) {
         super(description);
@@ -30,6 +31,11 @@ public class UserInteractionTaskImpl extends UserInteractionTask<TestProcessSubj
         this.leaveStepCalled = true;
     }
 
+    @Override
+    protected boolean isStayInThisTask(TestProcessSubject model){ // NOSONAR Parameter needed, if overridden
+        return stayInTask;
+    }
+
     @Override
     protected void onEnterStep(TestProcessSubject model) throws ProcessException {
         // implement empty
@@ -40,4 +46,5 @@ public class UserInteractionTaskImpl extends UserInteractionTask<TestProcessSubj
         super.enterStep(model);
         this.enterStepCalled = true;
     }
+
 }

gfsBackendService/src/test/java/org/eclipse/openk/gridfailureinformation/bpmn/base/tasks/UserInteractionTaskTest.java

@@ -27,6 +27,7 @@ public class UserInteractionTaskTest {
     @Test
     public void testUserinteractionTask() throws ProcessException {
         UserInteractionTaskImpl task=new UserInteractionTaskImpl("UI Task");
+        task.stayInTask = false;
         TestProcessSubject subject = new TestProcessSubject();
         task.enterStep( subject );
         assertTrue(task.enterStepCalled);
@@ -37,4 +38,18 @@ public class UserInteractionTaskTest {
 
     }
 
+    @Test
+    public void testUserinteractionTaskStayInTask() throws ProcessException {
+        UserInteractionTaskImpl task=new UserInteractionTaskImpl("UI Task");
+        task.stayInTask = true;
+        TestProcessSubject subject = new TestProcessSubject();
+
+        task.enterStep( subject );
+        assertTrue(task.enterStepCalled);
+        assertFalse(task.leaveStepCalled);
+
+        task.leaveStep( subject );
+        assertFalse(task.leaveStepCalled);
+
+    }
 }

gfsBackendService/src/test/java/org/eclipse/openk/gridfailureinformation/bpmn/impl/GfiGridTest.java

@@ -18,6 +18,7 @@ package org.eclipse.openk.gridfailureinformation.bpmn.impl;
 import org.eclipse.openk.gridfailureinformation.bpmn.base.*;
 import org.junit.jupiter.api.Test;
 
+import static org.hibernate.validator.internal.util.Contracts.assertNotNull;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
@@ -38,4 +39,11 @@ public class GfiGridTest {
         assertThrows(ProcessException.class, () -> theGrid.recover(subject).start(()-> ProcessStateImpl.UNREACHABLE) );
     }
 
+    // wegen intialer Testabdeckung
+    @Test
+    public void testGfiGridConstr() {
+        ProcessGrid grid = new GfiGrid();
+        assertNotNull(grid);
+    }
+
 }